Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Allow opening links in new tabs when HTML is trusted#14933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for making a pull request to jupyterlab! |
fcollonval commentedAug 9, 2023
Thanks@yuvipanda I expanded following the discussion at#14919 to dynamically styled the links in the frame when it is untrusted. Let me know what do you think? |
fcollonval commentedAug 9, 2023
Kicking CI following bot commit |
krassowski left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@yuvipanda and thank you@fcollonval - this solution is great!
Uh oh!
There was an error while loading.Please reload this page.
fcollonval commentedAug 9, 2023
Rephrase the warning
fcollonval commentedAug 9, 2023
The latest commit
|
krassowski left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor wording suggestions on tooltip.
Uh oh!
There was an error while loading.Please reload this page.
krassowski commentedAug 9, 2023
I wonder if "not trusted" would be more consistent. Also, we could set a non-serif font on the banner but it's all minor details. |
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Improve font family
fcollonval commentedAug 10, 2023
CI failure is not related - thanks@krassowski for the review |
fcollonval commentedAug 10, 2023
@meeseeksdev please backport to 4.0.x |
…ted (#14943)Co-authored-by: Yuvi Panda <yuvipanda@gmail.com>


References
Fixes#14919
Code changes
When user opts to trust a HTML file in the HTML viewer, allow code there to open
pages in a new tab by adding
allow-popupsto the IFrame's sandbox attribute.User-facing changes
Once a user trusts a HTML file, the file can open new windows either via JS or
via
target="_blank"links.