Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow opening links in new tabs when HTML is trusted#14933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fcollonval merged 8 commits intojupyterlab:mainfromyuvipanda:allow-popups
Aug 10, 2023

Conversation

@yuvipanda
Copy link
Contributor

References

Fixes#14919

Code changes

When user opts to trust a HTML file in the HTML viewer, allow code there to open
pages in a new tab by addingallow-popups to the IFrame's sandbox attribute.

User-facing changes

Once a user trusts a HTML file, the file can open new windows either via JS or
viatarget="_blank" links.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:Binder

@fcollonval
Copy link
Member

Thanks@yuvipanda

I expanded following the discussion at#14919 to dynamically styled the links in the frame when it is untrusted. Let me know what do you think?

add_link_styling

cc@krassowski

@fcollonval
Copy link
Member

Kicking CI following bot commit

Copy link
Member

@krassowskikrassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@yuvipanda and thank you@fcollonval - this solution is great!

@fcollonval
Copy link
Member

I changed the CSS selector (and add the tagsarea andform) and I change slightly the style of the warning to make it look like a banner:

image

Rephrase the warning
@fcollonval
Copy link
Member

The latest commit

  • add the case offormtarget
  • rephrase the warning toAction disabled as the file is untrusted. as button can become disabled; good English speaker feel free to suggest a better wording.

Copy link
Member

@krassowskikrassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor wording suggestions on tooltip.

@krassowski
Copy link
Member

I wonder if "not trusted" would be more consistent. Also, we could set a non-serif font on the banner but it's all minor details.

fcollonvaland others added2 commitsAugust 9, 2023 18:57
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Improve font family
@fcollonval
Copy link
Member

CI failure is not related - thanks@krassowski for the review

@fcollonvalfcollonval merged commit512d9ce intojupyterlab:mainAug 10, 2023
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull requestAug 10, 2023
fcollonval pushed a commit that referenced this pull requestAug 11, 2023
…ted (#14943)Co-authored-by: Yuvi Panda <yuvipanda@gmail.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@fcollonvalfcollonvalfcollonval left review comments

@krassowskikrassowskikrassowski approved these changes

Assignees

@yuvipandayuvipanda

Projects

None yet

Milestone

4.0.x

Development

Successfully merging this pull request may close these issues.

HTML Viewer can not open external links

3 participants

@yuvipanda@fcollonval@krassowski

[8]ページ先頭

©2009-2025 Movatter.jp