Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix CodeMirror theme selection background color#14841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@AllanChain
Copy link
Contributor

@AllanChainAllanChain commentedJul 18, 2023•
edited by krassowski
Loading

References

Fixes#14737

Code changes

Update the CSS selector for the selection background color.

Previously, the rule from the base CodeMirror6 theme.cm-focused > .cm-scroller > .cm-selectionLayer .cm-selectionBackground takes precedence over our.cm-focused .cm-selectionBackground rule, so the theme selection color is not taking effect. Changing the selector to be the same as the base theme fixes the issue.

User-facing changes

BeforeAfter
BeforeAfter

Backwards-incompatible changes

None.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:Binder

@welcome
Copy link

welcomebot commentedJul 18, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check outJupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the otherJovyans by joining ourDiscourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@krassowskikrassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@AllanChain.

Copy link
Member

@fcollonvalfcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@fcollonvalfcollonval merged commitfa96c72 intojupyterlab:mainJul 20, 2023
@welcome
Copy link

welcomebot commentedJul 20, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull requestJul 20, 2023
fcollonval pushed a commit that referenced this pull requestJul 23, 2023
…14864)Co-authored-by: Allan Chain <36528777+AllanChain@users.noreply.github.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@krassowskikrassowskikrassowski approved these changes

@fcollonvalfcollonvalfcollonval approved these changes

Assignees

@AllanChainAllanChain

Projects

None yet

Milestone

4.0.x

Development

Successfully merging this pull request may close these issues.

Theme problem: Focused selection always ends up with background #d7d4f0

3 participants

@AllanChain@fcollonval@krassowski
[8]ページ先頭
©2009-2025 Movatter.jp