Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
Bump the pre-commit group with 5 updates#2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,13 +1,13 @@ | ||||||
| repos: | ||||||
| - repo: https://github.com/codespell-project/codespell | ||||||
| rev: v2.4.2 | ||||||
| hooks: | ||||||
| - id: codespell | ||||||
| additional_dependencies: [tomli] | ||||||
| exclude: ^test/fixtures/ | ||||||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||||||
| rev: v0.15.5 | ||||||
| hooks: | ||||||
| - id: ruff-check | ||||||
| args: ["--fix"] | ||||||
| @@ -16,14 +16,14 @@ repos: | ||||||
| exclude: ^git/ext/ | ||||||
| - repo: https://github.com/shellcheck-py/shellcheck-py | ||||||
| rev: v0.11.0.1 | ||||||
| hooks: | ||||||
| - id: shellcheck | ||||||
| args: [--color] | ||||||
| exclude: ^test/fixtures/polyglot$|^git/ext/ | ||||||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||||||
| rev:v6.0.0 | ||||||
CopilotAI | ||||||
| rev:v6.0.0 | |
| rev:v5.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it was okay for this to be non-blocking, but it makes a reasonable point--although it's been a long time since ourpre-commit hooks all worked on the lowest version of Python that GitPython supports, it may make sense to do something to make this clear.
I think Copilot is correct that we can usedefault_language_version to make the hooks run with a different version. This feels like it would be even better, but I'm not sure. I think it would be confusing to have that happen when running it from inside a virtual environment for an earlier version, and still not work if no such interpreter is available. Therefore I suspect just a comment, or even just a clear note in the readme, would be better. But I haven't looked into it.
Uh oh!
There was an error while loading.Please reload this page.