Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Test Python 3.13 regularly on Ubuntu and macOS on CI#1990

Merged
Byron merged 1 commit intogitpython-developers:mainfrom
EliahKagan:py313-unix
Jan 5, 2025
Merged

Test Python 3.13 regularly on Ubuntu and macOS on CI#1990
Byron merged 1 commit intogitpython-developers:mainfrom
EliahKagan:py313-unix

Conversation

@EliahKagan
Copy link
Member

This enables testing Python 3.13 in the main CI test workflow for Ubuntu and macOS, as discussed in comments in#1989, but not Windows yet (pending#1955).

I think it makes sense to test these on CI, because:

  • They're working now, and if they stop working, we would want to know.
  • While Python 3.13 shouldn't be added as a classifier insetup.py yet since it's not fully working on Windows, testing other platforms on CI makes it easier for users to know they are meant (and believed) to work.
  • The Ubuntu and macOS job are fast, so this probably isn't adding too much load, delay, energy usage, etc.

@Byron
Copy link
Member

Thanks a lot!

EliahKagan reacted with thumbs up emoji

@EliahKagan
Copy link
MemberAuthor

No problem! It looks like this may have been meant to be merged. If so, auto-merge is still waiting on a review. (After it is merged, I'll rebase#1955 again.)

@ByronByron merged commit405b029 intogitpython-developers:mainJan 5, 2025
@Byron
Copy link
Member

Thanks for the reminder! Apparently merges only happen after approval. However, I noticed that once approved, they can be merged even while CI is running. Probably becausemain isn't protected.

@EliahKaganEliahKagan deleted the py313-unix branchJanuary 7, 2025 04:09
@EliahKagan
Copy link
MemberAuthor

It sounds like protectingmain may be the way to go, so that approvals can be made either before or after CI finishes, without risk of inadvertently merging something that fails the tests. Is there any reason not to do that? Are there any changes to the workflows themselves that should be made to go along with or support it?

@Byron
Copy link
Member

I took at look and it seems likemain is already protected, and as requirement for merging, an approval is set. What's also enabled is the need for checks to pass, but thanks to the worst UX, the checkbox does nothing. Instead, one has to pick each and every job individually, without a way to pick all at once.

This is where it stopped, again, and it's kind of where the famous auto-merge tends to stop for me 😅.

@EliahKagan
Copy link
MemberAuthor

If I understand correctly, this is more manageable ingitoxide due toGitoxideLabs/gitoxide@943350a (GitoxideLabs/gitoxide#1551), plus the refinement inGitoxideLabs/gitoxide@4e672ef (GitoxideLabs/gitoxide#1668). Sometime soon, I can look into making a PR here with something like that.

Byron reacted with heart emoji

EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 9, 2026
The status of 3.14 is now effectively the same as the status of3.13 when we started testing it ingitpython-developers#1990.This doesn't enable it on Windows yet, for the same reason that westill have not yet enabled regular CI tests of 3.13 on Windows. Itis hoped that 3.13 and 3.14 can be gotten fully working on Windows(rather than just mostly working, we think) soon; these exclusionsare meant to be temporary.Both the usual GIL interpreter and the free-threaded (nogil)intepreters are tested. See the immediately preceding commit on thetradeoffs involved in doing so.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 9, 2026
The status of 3.14 is now effectively the same as the status of3.13 when we started testing it ingitpython-developers#1990.This doesn't enable it on Windows yet, for the same reason that westill have not yet enabled regular CI tests of 3.13 on Windows. Itis hoped that 3.13 and 3.14 can be gotten fully working on Windows(rather than just mostly working, we think) soon; these exclusionsare meant to be temporary.Both the usual GIL interpreter and the free-threaded (nogil)intepreters are tested. See the immediately preceding commit on thetradeoffs involved in doing so.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 9, 2026
The status of 3.14 is now effectively the same as the status of3.13 when we started testing it ingitpython-developers#1990.This doesn't enable it on Windows yet, for the same reason that westill have not yet enabled regular CI tests of 3.13 on Windows. Itis hoped that 3.13 and 3.14 can be gotten fully working on Windows(rather than just mostly working, we think) soon; these exclusionsare meant to be temporary.Both the usual GIL interpreter and the free-threaded (nogil)intepreters are tested. See the immediately preceding commit on thetradeoffs involved in doing so.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ByronByronByron approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EliahKagan@Byron
[8]ページ先頭
©2009-2026 Movatter.jp