NotificationsYou must be signed in to change notification settings
Fork4.8k
Star26.1k

feat:`no-invalid-regexp` support`v` flag#17404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mdjermanovic merged 5 commits intoeslint:mainfromota-meshi:vavlid-regexp

Jul 25, 2023

Merged

feat:`no-invalid-regexp` support`v` flag#17404

mdjermanovic merged 5 commits intoeslint:mainfromota-meshi:vavlid-regexp

Jul 25, 2023

Conversation

Copy link

Member

ota-meshi commentedJul 23, 2023•
edited
Loading

Prerequisites checklist

I have read thecontributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Changes an existing rule (template)
[X] Other, please explain:

Update@eslint-community/regexpp to v4.6.0

What changes did you make? (Give an overview)

Refs#17223

This PR modifies theno-invalid-regexp rule and adds support for regexpv flag.

Is there anything you'd like reviewers to focus on?

ota-meshi added2 commits

July 23, 2023 11:00

feat:no-invalid-regexp supportv flag

e3348ef

fix: uv flags

7f935c3

ota-meshi requested a review froma team as acode owner

July 23, 2023 02:26

eslint-github-botbot added the featureThis change adds a new feature to ESLint label

Jul 23, 2023

Copy link

netlifybot commentedJul 23, 2023•
edited
Loading

✅ Deploy Preview fordocs-eslint canceled.

Name	Link
🔨 Latest commit	`1a775c4`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/64be875da9f1b50008d358bf

mdjermanovic added rule

Relates to ESLint's core rules

accepted

There is consensus among the team that this change meets the criteria for inclusion

new syntaxThis issue is related to new syntax that has reached stage 4 labels

Jul 23, 2023

Copy link

Member

mdjermanovic commentedJul 23, 2023

@ota-meshi can you also update package.json with"@eslint-community/regexpp": "^4.6.0" in this PR?

feat: update regexpp

44d165d

Copy link

MemberAuthor

ota-meshi commentedJul 23, 2023

I updated regexpp 👍

mdjermanovic reviewed

Jul 23, 2023

View reviewed changes

lib/rules/no-invalid-regexp.jsShow resolvedHide resolved

tests/lib/rules/no-invalid-regexp.jsShow resolvedHide resolved

mdjermanovic mentioned this pull request

Jul 23, 2023

Support RegExpv flag#17223

Closed

19 tasks

test: add test cases

2f25a57

Copy link

MemberAuthor

ota-meshi commentedJul 23, 2023

Thank you for checking this PR! I added test cases.

ota-meshi commented

Jul 23, 2023

View reviewed changes

tests/lib/rules/no-invalid-regexp.js Outdated

		code: "new RegExp('[[]\\\\u{0}' / valid only with `u` flag */, 'v')",
		errors: [{
		messageId: "regexMessage",
		data: { message: "Invalid regular expression: /[[]\\u{0}*/u: Unterminated character class" },

Copy link

MemberAuthor

ota-meshiJul 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I noticed that the error message issued by regexpp was wrong. i will fix the error message.

Copy link

Member

mdjermanovicJul 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Okay, waiting for the fix then. Otherwise, this LGTM.

Copy link

MemberAuthor

ota-meshiJul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I fixed the error message.
1a775c4

mdjermanovic added the contributor pool label

Jul 23, 2023

ota-meshi mentioned this pull request

Jul 23, 2023

fix: SyntaxError message for v flag with RegExpValidator#validatePatterneslint-community/regexpp#110

Merged

mdjermanovic mentioned this pull request

Jul 23, 2023

feat:no-useless-backreference supportv flag#17408

Merged

1 task

fix: error message and update regexpp to ^4.6.1

1a775c4

nzakas approved these changes

Jul 24, 2023

View reviewed changes

Copy link

Member

nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Just waiting for@mdjermanovic to verify his changes.

mdjermanovic approved these changes

Jul 25, 2023

View reviewed changes

Copy link

Member

mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

mdjermanovic merged commit94954a7 intoeslint:main

Jul 25, 2023

ota-meshi deleted the vavlid-regexp branch

July 26, 2023 07:40

eslint-github-botbot locked and limited conversation to collaborators

Jan 22, 2024

eslint-github-botbot added the archived due to ageThis issue has been archived; please open a new issue for any further discussion label

Jan 22, 2024

Labels

accepted

There is consensus among the team that this change meets the criteria for inclusion

archived due to age

This issue has been archived; please open a new issue for any further discussion

contributor pool feature

This change adds a new feature to ESLint

new syntax

This issue is related to new syntax that has reached stage 4

rule

Relates to ESLint's core rules

3 participants

Movatterモバイル変換

Uh oh!

feat:no-invalid-regexp supportv flag#17404

feat:no-invalid-regexp supportv flag#17404

Uh oh!

Conversation

ota-meshi commentedJul 23, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlifybot commentedJul 23, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fordocs-eslint canceled.

Uh oh!

mdjermanovic commentedJul 23, 2023

Uh oh!

ota-meshi commentedJul 23, 2023

Uh oh!

Uh oh!

Uh oh!

ota-meshi commentedJul 23, 2023

Uh oh!

ota-meshiJul 23, 2023

Choose a reason for hiding this comment

Uh oh!

mdjermanovicJul 23, 2023

Choose a reason for hiding this comment

Uh oh!

ota-meshiJul 24, 2023

Choose a reason for hiding this comment

Uh oh!

nzakas left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat:`no-invalid-regexp` support`v` flag#17404

feat:`no-invalid-regexp` support`v` flag#17404

ota-meshi commentedJul 23, 2023•
edited
Loading

netlifybot commentedJul 23, 2023•
edited
Loading