Movatterモバイル変換

This is the mail archive of thelibc-alpha@sourceware.orgmailing list for theglibc project.

Re: [PATCH] have ifunc resolver's return type match target

• From: Martin Sebor <msebor at gmail dot com>
• To: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
• Date: Wed, 23 Aug 2017 08:48:37 -0600
• Subject: Re: [PATCH] have ifunc resolver's return type match target
• Authentication-results: sourceware.org; auth=none
• References: <f967b8f5-6802-f848-ba68-b1df8069d379@gmail.com> <43124c3a-907c-3a55-4162-25cc714835c2@redhat.com>

On 08/23/2017 03:28 AM, Florian Weimer wrote:

On 08/21/2017 12:30 AM, Martin Sebor wrote:

The following GCC patch has been submitted for review.  Ithelps detect mismatches between the type of an ifunc or aliasdeclaration and the type of the resolver or alias.https://gcc.gnu.org/ml/gcc-patches/2017-08/msg01103.htmlTo let Glibc take advantage of this type checking and avoidwarnings when using the patched GCC when the change above iscommitted, the patch below adjusts the Glibc __ifunc_resolvermacro to declare the ifunc resolver so that its return typematches that of the target.  (I was going to wait to submit ituntil after the GCC patch has been accepted but per Joseph'ssuggestion I'm posting it here ahead of time.)

Do we have to backport both patches to older releases, too, so that theykeep building with a newer GCC?

It would make sense to me if that's how Glibc usually deals withthese sorts of things (i.e., changing code to avoid new warnings).The other (obvious) alternative is for people to suppress thewarnings when using the new compiler.Martin

• References:
  • [PATCH] have ifunc resolver's return type match target
    • From: Martin Sebor
  • Re: [PATCH] have ifunc resolver's return type match target
    • From: Florian Weimer