Movatterモバイル変換

This is the mail archive of thelibc-alpha@sourceware.orgmailing list for theglibc project.

Re: [PATCH] string/stratcliff.c: Replace int with size_t [BZ #21982]

• From: "H.J. Lu" <hjl dot tools at gmail dot com>
• To: Joseph Myers <joseph at codesourcery dot com>
• Cc: GNU C Library <libc-alpha at sourceware dot org>
• Date: Mon, 21 Aug 2017 06:51:28 -0700
• Subject: Re: [PATCH] string/stratcliff.c: Replace int with size_t [BZ #21982]
• Authentication-results: sourceware.org; auth=none
• References: <20170820171713.GA19531@gmail.com> <alpine.DEB.2.20.1708211322300.16038@digraph.polyomino.org.uk>

On Mon, Aug 21, 2017 at 6:23 AM, Joseph Myers <joseph@codesourcery.com> wrote:> On Sun, 20 Aug 2017, H.J. Lu wrote:>>> @@ -101,7 +101,7 @@ do_test (void)>>>>             if (STRLEN (&adr[outer]) != (size_t) (inner - outer))>>               {>> -               printf ("%s flunked for outer = %d, inner = %d\n",>> +               printf ("%s flunked for outer = %Zd, inner = %Zd\n",>> I don't think we should be using legacy %Z in any new code.  Use C99 %zu> for size_t (%zd only if the argument is the corresponding signed type> rather than size_t itself).>There are some %Zd in string/stratcliff.c.  Should they be changed?Since All of them are size_t, I will replace %Zd with %zu.-- H.J.

• Follow-Ups:
  • Re: [PATCH] string/stratcliff.c: Replace int with size_t [BZ #21982]
    • From: Joseph Myers

• References:
  • [PATCH] string/stratcliff.c: Replace int with size_t [BZ #21982]
    • From: H.J. Lu
  • Re: [PATCH] string/stratcliff.c: Replace int with size_t [BZ #21982]
    • From: Joseph Myers