Movatterモバイル変換

This is the mail archive of thelibc-alpha@sourceware.orgmailing list for theglibc project.

Re: [PATCH 05/27] arm64: fpsimd: Simplify uses of {set, clear}_ti_thread_flag()

• From: Alex Bennée <alex dot bennee at linaro dot org>
• To: Dave Martin <Dave dot Martin at arm dot com>
• Cc: linux-arm-kernel at lists dot infradead dot org, linux-arch at vger dot kernel dot org, libc-alpha at sourceware dot org, Ard Biesheuvel <ard dot biesheuvel at linaro dot org>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, Catalin Marinas <catalin dot marinas at arm dot com>, Will Deacon <will dot deacon at arm dot com>, Richard Sandiford <richard dot sandiford at arm dot com>, kvmarm at lists dot cs dot columbia dot edu
• Date: Fri, 18 Aug 2017 17:36:27 +0100
• Subject: Re: [PATCH 05/27] arm64: fpsimd: Simplify uses of {set, clear}_ti_thread_flag()
• Authentication-results: sourceware.org; auth=none
• References: <1502280338-23002-1-git-send-email-Dave.Martin@arm.com> <1502280338-23002-6-git-send-email-Dave.Martin@arm.com>

Dave Martin <Dave.Martin@arm.com> writes:> The existing FPSIMD context switch code contains a couple of> instances of {set,clear}_ti_thread(task_thread_info(task)).  Since> there are thread flag manipulators that operate directly on> task_struct, this verbosity isn't strictly needed.>> For consistency, this patch simplifies the affected calls.  This> should have no impact on behaviour.>> Signed-off-by: Dave Martin <Dave.Martin@arm.com>Reviewed-by: Alex Bennée <alex.bennee@linaro.org>> --->  arch/arm64/kernel/fpsimd.c | 6 ++---->  1 file changed, 2 insertions(+), 4 deletions(-)>> diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c> index 138fcfa..9c1f268e 100644> --- a/arch/arm64/kernel/fpsimd.c> +++ b/arch/arm64/kernel/fpsimd.c> @@ -159,11 +159,9 @@ void fpsimd_thread_switch(struct task_struct *next)>>  if (__this_cpu_read(fpsimd_last_state) == st>      && st->cpu == smp_processor_id())> -clear_ti_thread_flag(task_thread_info(next),> -     TIF_FOREIGN_FPSTATE);> +clear_tsk_thread_flag(next, TIF_FOREIGN_FPSTATE);>  else> -set_ti_thread_flag(task_thread_info(next),> -   TIF_FOREIGN_FPSTATE);> +set_tsk_thread_flag(next, TIF_FOREIGN_FPSTATE);>  }>  }--Alex Bennée

• References:
  • [PATCH 00/27] ARM Scalable Vector Extension (SVE)
    • From: Dave Martin
  • [PATCH 05/27] arm64: fpsimd: Simplify uses of {set,clear}_ti_thread_flag()
    • From: Dave Martin