Movatterモバイル変換

This is the mail archive of thelibc-alpha@sourceware.orgmailing list for theglibc project.

Re: [PATCH] _dl_init: Remove internal_function attribute

• From: "H.J. Lu" <hjl dot tools at gmail dot com>
• To: Florian Weimer <fweimer at redhat dot com>
• Cc: GNU C Library <libc-alpha at sourceware dot org>
• Date: Mon, 14 Aug 2017 05:42:48 -0700
• Subject: Re: [PATCH] _dl_init: Remove internal_function attribute
• Authentication-results: sourceware.org; auth=none
• References: <20170814113318.6885840138EE3@oldenburg.str.redhat.com> <CAMe9rOoFJgOZ8R85NWk6B-F6y1jT4mmdAS6BwtALu6HEfoFM-A@mail.gmail.com> <18aaf7e6-4f0f-cef4-970b-5c8490a1bc74@redhat.com>

On Mon, Aug 14, 2017 at 5:39 AM, Florian Weimer <fweimer@redhat.com> wrote:> On 08/14/2017 02:28 PM, H.J. Lu wrote:>>>         # Clear %ebp, so that even constructors have terminated backchain.\n\>>>         xorl %ebp, %ebp\n\>>> CFI adjustments are missing.>> The original code did not have any because we never unwind to this> frame, as indicated by the zero %ebp value.>> I can add CFI annotations for completeness, but I'd consider that  a> separate change.  It is also not quite clear to me what the canonical> frame address for the startup function should be.  We reach into the> caller's stack frame, after all.>The patch is fine then.Thanks.-- H.J.

• References:
  • [PATCH] _dl_init: Remove internal_function attribute
    • From: Florian Weimer
  • Re: [PATCH] _dl_init: Remove internal_function attribute
    • From: H.J. Lu
  • Re: [PATCH] _dl_init: Remove internal_function attribute
    • From: Florian Weimer