Movatterモバイル変換
[0]ホーム
This is the mail archive of thelibc-alpha@sourceware.orgmailing list for theglibc project.
[PATCH] x86: Remove __memset_zero_constant_len_parameter [BZ #21790]
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 4 Aug 2017 06:02:25 -0700
- Subject: [PATCH] x86: Remove __memset_zero_constant_len_parameter [BZ #21790]
- Authentication-results: sourceware.org; auth=none
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
__memset_zero_constant_len_parameter should be removed bycommit 61062f56304750c367c5c1533351621353c112a7Author: Ulrich Drepper <drepper@redhat.com>Date: Tue Mar 1 00:35:23 2005 +0000 2005-02-24 Roland McGrath <roland@redhat.com> * debug/Versions (libc: GLIBC_2.4): Remove __memset_zero_constant_len_parameter. * sysdeps/generic/memset_chk.c: Remove alias and warning. * misc/sys/cdefs.h (__warndecl): New macro. * debug/warning-nop.c: New file. * string/bits/string3.h (memset): Call __warn_memset_zero_len with no arguments, instead of calling __memset_zero_constant_len_parameter. Use __warndecl for __warn_memset_zero_len. * debug/Makefile (routines): Add $(static-only-routines). (static-only-routines): New variable.This patch removes the remaining pieces of it. Tested it on i586, i686and x86-64.I will check it in today.H.J.--[BZ #21790]* sysdeps/i386/i586/memset.S(__memset_zero_constant_len_parameter): Removed.* sysdeps/i386/i686/memset.S(__memset_zero_constant_len_parameter): Likewise.* sysdeps/i386/i686/multiarch/memset_chk.S(__memset_zero_constant_len_parameter): Likewise.* sysdeps/x86_64/memset.S (__memset_zero_constant_len_parameter):Likewise.--- sysdeps/i386/i586/memset.S | 7 ------- sysdeps/i386/i686/memset.S | 7 ------- sysdeps/i386/i686/multiarch/memset_chk.S | 6 +----- sysdeps/x86_64/memset.S | 6 ------ 4 files changed, 1 insertion(+), 25 deletions(-)diff --git a/sysdeps/i386/i586/memset.S b/sysdeps/i386/i586/memset.Sindex 4f8f1bcf94..a55e8c68cf 100644--- a/sysdeps/i386/i586/memset.S+++ b/sysdeps/i386/i586/memset.S@@ -112,10 +112,3 @@ L(2):shrl$2, %ecx/* convert byte count to longword count */ ret END (memset) libc_hidden_builtin_def (memset)--#if defined SHARED && IS_IN (libc) && !defined __memset_chk \- && !defined USE_AS_BZERO-strong_alias (__memset_chk, __memset_zero_constant_len_parameter)-.section .gnu.warning.__memset_zero_constant_len_parameter-.string "memset used with constant zero length parameter; this could be due to transposed parameters"-#endifdiff --git a/sysdeps/i386/i686/memset.S b/sysdeps/i386/i686/memset.Sindex 24d06178d2..a29b87ba09 100644--- a/sysdeps/i386/i686/memset.S+++ b/sysdeps/i386/i686/memset.S@@ -91,10 +91,3 @@ ENTRY (memset) ret END (memset) libc_hidden_builtin_def (memset)--#if defined SHARED && IS_IN (libc) && !defined __memset_chk \- && !defined USE_AS_BZERO-strong_alias (__memset_chk, __memset_zero_constant_len_parameter)-.section .gnu.warning.__memset_zero_constant_len_parameter-.string "memset used with constant zero length parameter; this could be due to transposed parameters"-#endifdiff --git a/sysdeps/i386/i686/multiarch/memset_chk.S b/sysdeps/i386/i686/multiarch/memset_chk.Sindex 573cf4208a..0580991ce4 100644--- a/sysdeps/i386/i686/multiarch/memset_chk.S+++ b/sysdeps/i386/i686/multiarch/memset_chk.S@@ -37,11 +37,7 @@ ENTRY(__memset_chk) 2:ret END(__memset_chk) -# ifdef SHARED-strong_alias (__memset_chk, __memset_zero_constant_len_parameter)-.section .gnu.warning.__memset_zero_constant_len_parameter-.string "memset used with constant zero length parameter; this could be due to transposed parameters"-# else+# ifndef SHARED .text .type __memset_chk_sse2, @function .p2align 4;diff --git a/sysdeps/x86_64/memset.S b/sysdeps/x86_64/memset.Sindex 41278787fe..f1245aec60 100644--- a/sysdeps/x86_64/memset.S+++ b/sysdeps/x86_64/memset.S@@ -59,9 +59,3 @@ libc_hidden_def (__wmemset) weak_alias (__wmemset, wmemset) libc_hidden_weak (wmemset) #endif--#if defined SHARED && IS_IN (libc) && !defined USE_MULTIARCH-strong_alias (__memset_chk, __memset_zero_constant_len_parameter)-.section .gnu.warning.__memset_zero_constant_len_parameter-.string "memset used with constant zero length parameter; this could be due to transposed parameters"-#endif-- 2.13.3
[8]ページ先頭