Movatterモバイル変換

This is the mail archive of thebinutils@sources.redhat.commailing list for thebinutils project.

Re: Alignment problem with PPC cross assembler (gcc code)

• From: Alan Modra <amodra at bigpond dot net dot au>
• To: binutils at sources dot redhat dot com
• Date: Thu, 19 Jun 2003 08:31:46 +0930
• Subject: Re: Alignment problem with PPC cross assembler (gcc code)
• References: <3EEF5140.34B08040@thales-tts.com> <20030618071429.GF12458@bubble.sa.bigpond.net.au>

On Wed, Jun 18, 2003 at 04:44:29PM +0930, Alan Modra wrote:> Back to a data subsection, a different one.  This one happens to follow> after the _testtask.rw_c[RW] subsection, which doesn't have any further> contents.  So this subsection starts at address 5.Which is where gas goes wrong.  The AIX assembler referencehttp://publibn.boulder.ibm.com/doc_link/en_US/a_doc_lib/aixassem/alangref/alangref.htmsays of csects:  "Alignment occurs at the beginning of the csect."* config/tc-ppc.c (ppc_csect): Pass alignment to ppc_change_csect.(ppc_change_csect): Add align param.  Align frag at start of csect.(ppc_section, ppc_named_section): Adjust ppc_change_csect calls.(ppc_frob_section): Align vma.Index: gas/config/tc-ppc.c===================================================================RCS file: /cvs/src/src/gas/config/tc-ppc.c,vretrieving revision 1.74diff -u -p -r1.74 tc-ppc.c--- gas/config/tc-ppc.c18 Jun 2003 03:27:18 -00001.74+++ gas/config/tc-ppc.c18 Jun 2003 11:09:33 -0000@@ -111,7 +111,7 @@ static void ppc_ec PARAMS ((int)); static void ppc_ef PARAMS ((int)); static void ppc_es PARAMS ((int)); static void ppc_csect PARAMS ((int));-static void ppc_change_csect PARAMS ((symbolS *));+static void ppc_change_csect PARAMS ((symbolS *, offsetT)); static void ppc_function PARAMS ((int)); static void ppc_extern PARAMS ((int)); static void ppc_lglobl PARAMS ((int));@@ -3006,6 +3006,7 @@ ppc_csect (ignore)   char *name;   char endc;   symbolS *sym;+  offsetT align;    name = input_line_pointer;   endc = get_symbol_end ();@@ -3020,22 +3021,24 @@ ppc_csect (ignore)       symbol_get_tc (sym)->class = XMC_PR;     } -  ppc_change_csect (sym);-+  align = 2;   if (*input_line_pointer == ',')     {       ++input_line_pointer;-      symbol_get_tc (sym)->align = get_absolute_expression ();+      align = get_absolute_expression ();     } +  ppc_change_csect (sym, align);+   demand_empty_rest_of_line (); }  /* Change to a different csect.  */  static void-ppc_change_csect (sym)+ppc_change_csect (sym, align)      symbolS *sym;+     offsetT align; {   if (S_IS_DEFINED (sym))     subseg_set (S_GET_SEGMENT (sym), symbol_get_tc (sym)->subseg);@@ -3045,11 +3048,14 @@ ppc_change_csect (sym)       int after_toc;       int hold_chunksize;       symbolS *list;+      int is_code;+      segT sec;        /* This is a new csect.  We need to look at the symbol class to  figure out whether it should go in the text section or the  data section.  */       after_toc = 0;+      is_code = 0;       switch (symbol_get_tc (sym)->class) { case XMC_PR:@@ -3064,6 +3070,7 @@ ppc_change_csect (sym)   symbol_get_tc (sym)->subseg = ppc_text_subsegment;   ++ppc_text_subsegment;   list_ptr = &ppc_text_csects;+  is_code = 1;   break; case XMC_RW: case XMC_TC0:@@ -3091,18 +3098,24 @@ ppc_change_csect (sym)       hold_chunksize = chunksize;       chunksize = 64; -      subseg_new (segment_name (S_GET_SEGMENT (sym)),-  symbol_get_tc (sym)->subseg);+      sec = subseg_new (segment_name (S_GET_SEGMENT (sym)),+symbol_get_tc (sym)->subseg);        chunksize = hold_chunksize;        if (after_toc) ppc_after_toc_frag = frag_now; +      record_alignment (sec, align);+      if (is_code)+frag_align_code (align, 0);+      else+frag_align (align, 0, 0);+       symbol_set_frag (sym, frag_now);       S_SET_VALUE (sym, (valueT) frag_now_fix ()); -      symbol_get_tc (sym)->align = 2;+      symbol_get_tc (sym)->align = align;       symbol_get_tc (sym)->output = 1;       symbol_get_tc (sym)->within = sym; @@ -3140,7 +3153,7 @@ ppc_section (type)    sym = symbol_find_or_make (name); -  ppc_change_csect (sym);+  ppc_change_csect (sym, 2);    demand_empty_rest_of_line (); }@@ -3177,7 +3190,7 @@ ppc_named_section (ignore)    sym = symbol_find_or_make (real_name); -  ppc_change_csect (sym);+  ppc_change_csect (sym, 2);    demand_empty_rest_of_line (); }@@ -5049,6 +5062,7 @@ ppc_frob_section (sec) {   static bfd_size_type vma = 0; +  vma = md_section_align (sec, vma);   bfd_set_section_vma (stdoutput, sec, vma);   vma += bfd_section_size (stdoutput, sec); }-- Alan ModraIBM OzLabs - Linux Technology Centre

• References:
  • Alignment problem with PPC cross assembler (gcc code)
    • From: Trevor Marshall
  • Re: Alignment problem with PPC cross assembler (gcc code)
    • From: Alan Modra