Movatterモバイル変換

This is the mail archive of thebinutils@sources.redhat.commailing list for thebinutils project.

Re: [PATCH] MIPS gas: Cleanup address insn conditionals

• From: cgd at broadcom dot com
• To: ica2_ts at csv dot ica dot uni-stuttgart dot de
• Cc: binutils at sources dot redhat dot com
• Date: 15 Jun 2003 21:51:25 -0700
• Subject: Re: [PATCH] MIPS gas: Cleanup address insn conditionals
• References: <20030615202246.GC14156@rembrandt.csv.ica.uni-stuttgart.de><mailpost.1055708605.24715@news-sj1-1>

At Sun, 15 Jun 2003 20:23:25 +0000 (UTC), "Thiemo Seufer" wrote:> +#define ADDRESS_ADD_INSN\> +   (HAVE_32BIT_ADDRESSES ? HAVE_NEWABI ? "add" : "addu" : "daddu")> +> +#define ADDRESS_ADDI_INSN\> +   (HAVE_32BIT_ADDRESSES ? HAVE_NEWABI ? "addi" : "addiu" : "daddiu")Could you please add more parens to these?If somebody has to go look at the C operator precedence rules to tellwhat is meant, something is wrong.  (yes, *I*'d have to go look at therules to figure out what the above means, unless i derive it from myunderstanding the ABIs in question.)I know, it's the way the code was before, but that doesn't mean it wasgood...cgd

• References:
  • [PATCH] MIPS gas: Cleanup address insn conditionals
    • From: Thiemo Seufer