Movatterモバイル変換

This is the mail archive of thebinutils@sources.redhat.commailing list for thebinutils project.

Re: Objdump crash on prelinked ARM binaries

• From: Daniel Jacobowitz <drow at mvista dot com>
• To: binutils at sources dot redhat dot com
• Date: Thu, 5 Jun 2003 22:14:10 -0400
• Subject: Re: Objdump crash on prelinked ARM binaries
• References: <20030605134709.GA30351@nevyn.them.org> <20030605153629.GA27144@nevyn.them.org>

On Thu, Jun 05, 2003 at 11:36:29AM -0400, Daniel Jacobowitz wrote:> On Thu, Jun 05, 2003 at 09:47:09AM -0400, Daniel Jacobowitz wrote:> > arm-linux targets only provide elf_info_to_howto_rel.  Then, when objdump> > finds Rela relocations in a prelinked object file, it dereferences a NULL> > pointer trying to call ebd->elf_info_to_howto.  Will it break anything to> > always provide both elf_info_to_howto functions?> > It doesn't appear to break anything.  Is this OK?I've checked in this version instead, approved by Nick off-list. Thanks, Nick.-- Daniel JacobowitzMontaVista Software                         Debian GNU/Linux Developer2003-06-05  Daniel Jacobowitz  <drow@mvista.com>* elfcode.h (elf_slurp_reloc_table_from_section): Don't dereferenceNULL function pointers.Index: elfcode.h===================================================================RCS file: /big/fsf/rsync/src-cvs/src/bfd/elfcode.h,vretrieving revision 1.42diff -u -p -r1.42 elfcode.h--- elfcode.h21 May 2003 00:56:05 -00001.42+++ elfcode.h5 Jun 2003 16:20:17 -0000@@ -1363,7 +1363,9 @@ elf_slurp_reloc_table_from_section (abfd        relent->addend = rela.r_addend; -      if (entsize == sizeof (Elf_External_Rela))+      if ((entsize == sizeof (Elf_External_Rela)+   && ebd->elf_info_to_howto != NULL)+  || ebd->elf_info_to_howto_rel == NULL) (*ebd->elf_info_to_howto) (abfd, relent, &rela);       else (*ebd->elf_info_to_howto_rel) (abfd, relent, &rela);

• References:
  • Objdump crash on prelinked ARM binaries
    • From: Daniel Jacobowitz
  • Re: Objdump crash on prelinked ARM binaries
    • From: Daniel Jacobowitz