Movatterモバイル変換

This is the mail archive of thebinutils@sources.redhat.commailing list for thebinutils project.

Re: PATCH: Better messages for discarde section

• From: Nick Clifton <nickc at redhat dot com>
• To: "H. J. Lu" <hjl at lucon dot org>
• Cc: binutils at sources dot redhat dot com
• Date: Tue, 03 Jun 2003 17:46:25 +0100
• Subject: Re: PATCH: Better messages for discarde section
• References: <20030530131718.A9042@lucon.org> <m3fzmrkzkq.fsf@redhat.com><20030603082539.A19057@lucon.org>

Hi H.J.>> asprintf() returns 0 if it failed to allocate the memory, not -1.> Linux's asprintf returns -1 on error.Really ?  The one in libiberty returns 0.  Oh well.> I changed it to "ok <= 0".Thanks.>> > -error_handler VPARAMS ((int id ATTRIBUTE_UNUSED, const char *fmt, ...))>> > +error_handler (int id, const char *fmt, ...)>> >  {>> > -  VA_OPEN (arg, fmt);>> > -  VA_FIXEDARG (arg, const char *, fmt);>> >> Please do not remove the V.... macros. We have not switched over to>> using IsoC.  (Well not yet anyway). >> I am not sure if I have a choice here since va_copy is used, which> is not available in K&R C.Why are you using va_copy ?  If it is only because of the recursivecall to einfo() inside your new code, then it might be cleaner to justset a flag and then tail-call einfo at the end of the function.  Thatway it should work with K&R as well.> +    case -LD_DEFINITION_IN_DISCARDED_SECTION:> +    case LD_DEFINITION_IN_DISCARDED_SECTION:What is the purpose of the negative version ofLD_DEFINITION_IN_DISCARDED_SECTION ?  Does anything use it ?  Assumingthat it is needed, it ought to be documented in a comment somewhere.Cheers        Nick

• Follow-Ups:
  • Re: PATCH: Better messages for discarde section
    • From: Ian Lance Taylor
  • Re: PATCH: Better messages for discarde section
    • From: H. J. Lu

• References:
  • Re: PATCH: Better messages for discarde section
    • From: Nick Clifton
  • Re: PATCH: Better messages for discarde section
    • From: H. J. Lu