Movatterモバイル変換

This is the mail archive of thebinutils@sources.redhat.commailing list for thebinutils project.

Re: PATCH: Better messages for discarde section

• From: "H. J. Lu" <hjl at lucon dot org>
• To: Nick Clifton <nickc at redhat dot com>
• Cc: binutils at sources dot redhat dot com
• Date: Tue, 3 Jun 2003 08:25:39 -0700
• Subject: Re: PATCH: Better messages for discarde section
• References: <20030530131718.A9042@lucon.org> <m3fzmrkzkq.fsf@redhat.com>

On Tue, Jun 03, 2003 at 03:25:41PM +0100, Nick Clifton wrote:> > +      ok = asprintf (&buf, "local symbol %d",> > +     count++);> > +      if (ok == -1)> > +buf = (char *) "local symbol";> > asprintf() returns 0 if it failed to allocate the memory, not -1.> Linux's asprintf returns -1 on error. I changed it to "ok <= 0".> > > --- binutils/include/bfdlink.h.discard2003-05-21 14:36:18.000000000 -0700> > +++ binutils/include/bfdlink.h2003-05-30 11:56:02.000000000 -0700> > @@ -643,4 +643,7 @@ struct bfd_elf_version_tree> >    int used;> >  };> >  > > +/* Identifiers of linker error messages.  */> > +#define LD_DEFINITION_IN_DISCARDED_SECTION1> > Since this is defining a value to be passed as the 'id' field of the> error_handler function in the bfd_link_callbacks structure, it really> ought to be defined near where the error_handler field is defined,> rather than at the end of the function.> I moved it just below error_handler.> > > +++ binutils/ld/ldmisc.c2003-05-30 13:06:52.000000000 -0700> > @@ -22,6 +22,7 @@> >     02111-1307, USA.  */> >  > >  #include "bfd.h"> > +#include "bfdlink.h"> > You are adding a dependency in ldmisc.c.  You should run "make dep" to> update ld/Makefile.am to reflect this.Done.> > > > -error_handler VPARAMS ((int id ATTRIBUTE_UNUSED, const char *fmt, ...))> > +error_handler (int id, const char *fmt, ...)> >  {> > -  VA_OPEN (arg, fmt);> > -  VA_FIXEDARG (arg, const char *, fmt);> > Please do not remove the V.... macros. We have not switched over to> using IsoC.  (Well not yet anyway). > I am not sure if I have a choice here since va_copy is used, whichis not available in K&R C. Does anyone how to handle it in K&R?Here is the new one.Thanks.H.J.

Attachment:binutils-discard.patch
Description: Text document

• Follow-Ups:
  • Re: PATCH: Better messages for discarde section
    • From: Nick Clifton

• References:
  • Re: PATCH: Better messages for discarde section
    • From: Nick Clifton