Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
feat: http2 support forconnect compatibility application#5267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
68eefa4 to56a6dcaCompare56a6dca toff7f35aCompareAll works fine except a deprecation warning -pillarjs/finalhandler#45, we can fix it here, I want to make a small patch and when it will be resolved we remove it |
| */ | ||
| constallHeaders=[]; | ||
| allHeaders.push({key:"X_TEST",value:"TEST"}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I just wondered after upgrading towebpack-dev-server 5.2.1 where this header is coming from and could track it down to this PR. Looks like it's there for quite some time already and I simply didn't notice until now. Does this serve any purpose or is it maybe a left-over from some testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like we I don't see it when merging, let's fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Allow to use
http2withconnect,expressstill doesn't support http2Breaking Changes
No
Additional Info
No