Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(deps): Replacerimraf withrm, moverimraf to a dev dep#5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alexander-akait merged 1 commit intowebpack:masterfromaskoufis:rimraf-dev-dep
Apr 24, 2024
Merged

fix(deps): Replacerimraf withrm, moverimraf to a dev dep#5162

alexander-akait merged 1 commit intowebpack:masterfromaskoufis:rimraf-dev-dep
Apr 24, 2024

Conversation

@askoufis
Copy link
Contributor

@askoufisaskoufis commentedApr 23, 2024
edited
Loading

  • This is abugfix
  • This is afeature
  • This is acode refactor
  • This is atest update
  • This is adocs update
  • This is ametadata update

For Bugs and Features; did you add new tests?

No fixes or features

Motivation / Use-Case

Now that this package's minimum supported node version is high enough, and given the relatively simple use case thatrimraf is used for at runtime, IMO it's worth just using node'srm instead (viagraceful-fs).

There is one morerimraf usage inside a test, but I figured that could stay. Happy to remove that too, thoughrimraf is still used as a CLI so it has to stay at least as a dev dep.

Breaking Changes

None

Additional Info

None

@alexander-akait
Copy link
Member

Great job 👍

askoufis reacted with heart emoji

@askoufis
Copy link
ContributorAuthor

askoufis commentedApr 24, 2024
edited
Loading

Should I rename the commit and force push so commitlint will pass?

@alexander-akait
Copy link
Member

Ignore it, I will rename when will merge

askoufis reacted with thumbs up emoji

@alexander-akait
Copy link
Member

Looks like github actions is down -https://www.githubstatus.com/, I will rerun it when it will work

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alexander-akaitalexander-akaitalexander-akait approved these changes

@hiroppyhiroppyAwaiting requested review from hiroppy

@snitin315snitin315Awaiting requested review from snitin315

@anshumanvanshumanvAwaiting requested review from anshumanv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@askoufis@alexander-akait

[8]ページ先頭

©2009-2025 Movatter.jp