Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/corePublic

fix(watch): updateoldValue before runningcb to prevent stale value#12296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
edison1105 merged 4 commits intovuejs:mainfromjh-leong:fix/12294
May 20, 2025

Conversation

@jh-leong
Copy link
Member

@jh-leongjh-leong commentedOct 30, 2024•
edited by coderabbitaibot
Loading

close#12294

Summary by CodeRabbit

  • Bug Fixes

    • Improved reactivity behavior to ensure watched values are updated correctly during synchronous watcher callbacks.

  • Tests

    • Added a new test case to verify immediate reset functionality with synchronous watchers.

skirtles-code reacted with thumbs up emoji
@github-actions
Copy link

github-actionsbot commentedOct 30, 2024•
edited
Loading

Size Report

Bundles

FileSizeGzipBrotli
runtime-dom.global.prod.js101 kB38.3 kB (-1 B)34.5 kB (+13 B)
vue.global.prod.js159 kB58.5 kB52 kB (+6 B)

Usages

NameSizeGzipBrotli
createApp (CAPI only)46.6 kB18.2 kB16.7 kB
createApp54.5 kB21.2 kB19.4 kB (-1 B)
createSSRApp58.8 kB23 kB20.9 kB (+1 B)
defineCustomElement59.5 kB22.8 kB (+1 B)20.8 kB (-10 B)
overall68.6 kB26.4 kB24.1 kB (-5 B)

@pkg-pr-new
Copy link

pkg-pr-newbot commentedOct 30, 2024•
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12296

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12296

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12296

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12296

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12296

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12296

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12296

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12296

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12296

vue

npm i https://pkg.pr.new/vue@12296

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12296

commit:9623e8f

@edison1105edison1105 added ready to mergeThe PR is ready to be merged. scope: reactivity labelsOct 30, 2024
@edison1105edison1105 added the 🔨 p3-minor-bugPriority 3: this fixes a bug, but is an edge case that only affects very specific usage. labelMay 19, 2025
@coderabbitai
Copy link

coderabbitaibot commentedMay 19, 2025•
edited
Loading

Walkthrough

A new test case was added to thewatch test suite to verify watcher behavior when the watched value is reset synchronously. Thewatch implementation was modified to update theoldValue before invoking the callback, ensuring correct watcher firing in synchronous scenarios. No changes to public APIs were made.

Changes

File(s)Change Summary
packages/reactivity/tests/watch.spec.tsAdded a test for "watch with immediate reset and sync flush" to validate watcher reset behavior.
packages/reactivity/src/watch.tsMovedoldValue assignment before callback in watcher logic to ensure correct firing.

Sequence Diagram(s)

sequenceDiagram    participant ReactiveRef as Reactive Reference    participant Watcher as Watcher    participant Callback as Watch Callback    ReactiveRef->>Watcher: Value changes (e.g., to true)    Watcher->>Watcher: Update oldValue = newValue    Watcher->>Callback: Invoke callback (may reset value)    Callback->>ReactiveRef: Optionally reset value (e.g., to false)    loop If value changes again        ReactiveRef->>Watcher: Value changes (again)        Watcher->>Watcher: Update oldValue = newValue        Watcher->>Callback: Invoke callback    end
Loading

Assessment against linked issues

ObjectiveAddressedExplanation
Ensure synchronous watchers fire correctly when the watched value is reset in the callback (#12294)✅

Poem

A watcher peeks with eager eyes,
At values flipping, truth and lies.
Now old and new are set just right,
No sneaky bugs escape the night.
With tests to prove our code is sound,
The sync-watch rabbit hops around! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between163b365 and6f20660.

📒 Files selected for processing (2)
  • packages/reactivity/__tests__/watch.spec.ts (1 hunks)
  • packages/reactivity/src/watch.ts (1 hunks)
🔇 Additional comments (2)
packages/reactivity/src/watch.ts (1)

267-267:Critical bugfix that prevents stale values in synchronous watch callbacks

This change ensures that theoldValue is updated before the callback is invoked, which is essential for cases where the callback might trigger additional synchronous changes to the watched value. Previously, theoldValue was updated after the callback, which could lead to incorrect behavior in watchers that immediately reset the watched value.

packages/reactivity/__tests__/watch.spec.ts (1)

281-291:Excellent test case that verifies the bugfix

This test properly validates the fix for issue#12294 by creating a scenario where a watcher callback immediately resets the watched value. The test confirms that when setting the value totrue twice in succession, the final value is correctly reset tofalse, demonstrating that the watcher fires appropriately for each change.

The test case is well-designed:

  1. It creates a reactive ref with an initial value offalse
  2. Sets up a watcher that resets the value tofalse whenever it changes
  3. Makes multiple consecutive assignments totrue
  4. Verifies the watcher behaves correctly by resetting tofalse
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a.coderabbit.yaml file to the root of your repository.
  • Please see theconfiguration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

@edison1105
Copy link
Member

/ecosystem-ci run

github-actions[bot] reacted with thumbs up emoji

@vuejsvuejs deleted a comment fromjh-leongMay 20, 2025
@vuejsvuejs deleted a comment fromjh-leongMay 20, 2025
@vue-bot
Copy link
Contributor

📝 Ran ecosystem CI:Open

suiteresultlatest scheduled
language-tools✅success✅success
pinia✅success✅success
nuxt✅success✅success
primevue✅success✅success
test-utils✅success✅success
quasar✅success✅success
router✅success✅success
vitepress✅success✅success
radix-vue✅success✅success
vite-plugin-vue✅success✅success
vue-i18n✅success✅success
vue-macros✅success✅success
vuetify✅success✅success
vue-simple-compiler✅success✅success
vant✅success✅success
vueuse✅success✅success

@edison1105edison1105 merged commitc69c4bb intovuejs:mainMay 20, 2025
14 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@edison1105edison1105edison1105 approved these changes

Assignees

No one assigned

Labels

🔨 p3-minor-bugPriority 3: this fixes a bug, but is an edge case that only affects very specific usage.ready to mergeThe PR is ready to be merged.scope: reactivity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Synchronous watchers can fail to fire

3 participants

@jh-leong@edison1105@vue-bot
[8]ページ先頭
©2009-2025 Movatter.jp