Adds total test run times of each blob in test report of--merge-reports run. TheDuration is sum of all blobs. Below it we showPer blob durations.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes topnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests withpnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation withpnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages withfeat:,fix:,perf:,docs:, orchore:.

AriPerkkio force-pushed thefix/merge-reports-execution-times branch 3 times, most recently from6ba3c89 tob996dbfCompare

April 24, 2025 12:22

Copy link

netlifybot commentedApr 24, 2025•
edited
Loading

✅ Deploy Preview forvitest-dev ready!

Builtwithout sensitive environment variables

Name	Link
🔨 Latest commit	`c2044d7`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/681780b3124da8000826fe5f
😎 Deploy Preview	https://deploy-preview-7877--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

AriPerkkio force-pushed thefix/merge-reports-execution-times branch fromb996dbf to67ef233Compare

April 24, 2025 12:38

AriPerkkio marked this pull request as ready for review

April 24, 2025 12:53

sheremet-va requested changes

Apr 24, 2025

View reviewed changes

packages/vitest/src/node/core.ts OutdatedShow resolvedHide resolved

test/reporters/tests/merge-reports.test.ts OutdatedShow resolvedHide resolved

AriPerkkio force-pushed thefix/merge-reports-execution-times branch 2 times, most recently from4f540be tod02dca4Compare

April 29, 2025 06:14

sheremet-va reviewed

Apr 29, 2025

View reviewed changes

Copy link

Member

sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Generally, I dislikeexecutionTimes?: number[] as a public API.

What are these numbers? Why are the optional? Do we just keep adding new arguments to hooks? I think this needs to be standardizedsomehow

Maybe have something like aSubTestRun? OrShardTestRun

packages/vitest/src/node/types/reporter.ts OutdatedShow resolvedHide resolved

packages/vitest/src/node/test-run.ts OutdatedShow resolvedHide resolved

Copy link

MemberAuthor

AriPerkkio commentedApr 29, 2025

Do you have any suggestions what would be better way to pass data fromblob reporter'sreadBlob to other reporters? Should we instead store it inctx orctx.state?

Copy link

Member

sheremet-va commentedApr 29, 2025

Do you have any suggestions what would be better way to pass data fromblob reporter'sreadBlob to other reporters? Should we instead store it inctx orctx.state?

Storing it inctx.state seems like an interesting idea actually 🤔 Something likectx.state.blobs?