Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(browser): fixtoHaveClass typing#7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawahi-ogawa commentedJan 30, 2025
edited
Loading

Description

I think there's some dts specific magic going on as to why standard overload is not working. I couldn't figure that out, so I went for a different way and made a union on argument types, which should achieves the same for user's type safety.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes topnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests withpnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation withpnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages withfeat:,fix:,perf:,docs:, orchore:.

amanmahajan7 reacted with thumbs up emoji
@netlifyNetlify
Copy link

netlifybot commentedJan 30, 2025

Deploy Preview forvitest-dev ready!

Builtwithout sensitive environment variables

NameLink
🔨 Latest commitf6bef70
🔍 Latest deploy loghttps://app.netlify.com/sites/vitest-dev/deploys/679ad5a3145c970008d1d33a
😎 Deploy Previewhttps://deploy-preview-7383--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@pkg-pr-newpkg.pr.new
Copy link

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7383

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7383

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7383

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7383

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7383

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7383

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7383

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7383

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7383

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7383

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7383

vite-node

npm i https://pkg.pr.new/vite-node@7383

vitest

npm i https://pkg.pr.new/vitest@7383

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7383

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7383

commit:f6bef70

@hi-ogawahi-ogawa marked this pull request as ready for reviewJanuary 30, 2025 01:34
@sheremet-vasheremet-va merged commit7ef238c intovitest-dev:mainFeb 4, 2025
15 checks passed
@hi-ogawahi-ogawa deleted the fix-toHaveClass-exact branchFebruary 4, 2025 23:21
renovatebot added a commit to mmkal/expect-type that referenced this pull requestFeb 18, 2025
##### [v3.0.6](https://github.com/vitest-dev/vitest/releases/tag/v3.0.6)#####    🐞 Bug Fixes-   Fix `getMockedSystemTime` for `useFakeTimer`  -  by [@hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7405 [<samp>(03912)</samp>](vitest-dev/vitest@03912b43)-   Compat for jest-image-snapshot  -  by [@hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7390 [<samp>(9542b)</samp>](vitest-dev/vitest@9542b699)-   Ensure project names are readable in dark terminals  -  by [@rgrove](https://github.com/rgrove) invitest-dev/vitest#7371 [<samp>(bb94c)</samp>](vitest-dev/vitest@bb94c19f)-   Exclude `queueMicrotask` from default fake timers to not break node fetch  -  by [@hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7505 [<samp>(167a9)</samp>](vitest-dev/vitest@167a98d7)-   **browser**:    -   Fix mocking modules out of root  -  by [@hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7415 [<samp>(d3acb)</samp>](vitest-dev/vitest@d3acbd8b)    -   Fix `toHaveClass` typing  -  by [@hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7383 [<samp>(7ef23)</samp>](vitest-dev/vitest@7ef238c0)    -   Relax locator selectors methods  -  by [@sheremet-va](https://github.com/sheremet-va) invitest-dev/vitest#7422 [<samp>(1b8c5)</samp>](vitest-dev/vitest@1b8c5c9e)    -   Resolve thread count from `maxWorkers`  -  by [@AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7483 [<samp>(adbb2)</samp>](vitest-dev/vitest@adbb25ab)    -   Cleanup timeout on resolve and give more information in the error  -  by [@sheremet-va](https://github.com/sheremet-va) invitest-dev/vitest#7487 [<samp>(5a45a)</samp>](vitest-dev/vitest@5a45a7ca)-   **coverage**:    -   `vite-node` to pass correct execution wrapper offset  -  by [@AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7417 [<samp>(1f2e5)</samp>](vitest-dev/vitest@1f2e5552)    -   Preserve moduleExecutionInfo in non-isolated runs  -  by [@AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7486 [<samp>(f31a0)</samp>](vitest-dev/vitest@f31a07bb)-   **deps**:    -   Update all non-major dependencies  -  by [@hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7363 [<samp>(e348b)</samp>](vitest-dev/vitest@e348bd4c)    -   Update all non-major dependencies  -  by [@hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7507 [<samp>(6cc40)</samp>](vitest-dev/vitest@6cc408d6)-   **init**:    -   Invalid browser config  -  by [@AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7475 [<samp>(8fe64)</samp>](vitest-dev/vitest@8fe641b4)-   **reporters**:    -   Render tasks in tree when in TTY  -  by [@AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7503 [<samp>(027ce)</samp>](vitest-dev/vitest@027ce9bb)-   **vite-node**:    -   Remove fake first line mapping on Vite 6  -  by [@hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7124 [<samp>(b9973)</samp>](vitest-dev/vitest@b997355b)-   **watch**:    -   Properly remove cache after removing existing test files  -  by [@soc221b](https://github.com/soc221b) invitest-dev/vitest#7399 [<samp>(01a59)</samp>](vitest-dev/vitest@01a59721)-   **workspace**:    -   Forward `inspect` related cli options  -  by [@AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7373 [<samp>(ed15b)</samp>](vitest-dev/vitest@ed15b5b3)#####     [View changes on GitHub](vitest-dev/vitest@v3.0.5...v3.0.6)
jelmore1674 pushed a commit to jelmore1674/build-changelog that referenced this pull requestMar 19, 2025
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/main/packages/coverage-v8#readme) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8)) | devDependencies | patch | [`3.0.5` -> `3.0.7`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-v8/3.0.5/3.0.7) || [vitest](https://github.com/vitest-dev/vitest) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | devDependencies | patch | [`3.0.5` -> `3.0.7`](https://renovatebot.com/diffs/npm/vitest/3.0.5/3.0.7) |---### Release Notes<details><summary>vitest-dev/vitest (@&#8203;vitest/coverage-v8)</summary>### [`v3.0.7`](https://github.com/vitest-dev/vitest/releases/tag/v3.0.7)[Compare Source](vitest-dev/vitest@v3.0.6...v3.0.7)#####    🐞 Bug Fixes-   **browser**: Support webdriverio 9  -  by [@&#8203;sheremet-va](https://github.com/sheremet-va) invitest-dev/vitest#7553 [<samp>(b1949)</samp>](vitest-dev/vitest@b1949c97)-   **deps**: Update all non-major dependencies  -  invitest-dev/vitest#7543 [<samp>(365ff)</samp>](vitest-dev/vitest@365ffe6b)-   **expect**: Correct generic MatchersObject this type in expect.extend  -  by [@&#8203;Workingstiff-s](https://github.com/Workingstiff-s) invitest-dev/vitest#7526 [<samp>(d5765)</samp>](vitest-dev/vitest@d5765f71)-   **mocker**: Include more modules to prefix-only module list  -  by [@&#8203;btea](https://github.com/btea) invitest-dev/vitest#7524 [<samp>(a12ec)</samp>](vitest-dev/vitest@a12ec008)-   **spy**: Clear/reset/restore mocks in stack order  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7499 [<samp>(f7100)</samp>](vitest-dev/vitest@f71004ff)#####    🏎 Performance-   **browser**: Do wdio context switching only once per file  -  by [@&#8203;sheremet-va](https://github.com/sheremet-va) invitest-dev/vitest#7549 [<samp>(aaa58)</samp>](vitest-dev/vitest@aaa58556)#####     [View changes on GitHub](vitest-dev/vitest@v3.0.6...v3.0.7)### [`v3.0.6`](https://github.com/vitest-dev/vitest/releases/tag/v3.0.6)[Compare Source](vitest-dev/vitest@v3.0.5...v3.0.6)#####    🐞 Bug Fixes-   Fix `getMockedSystemTime` for `useFakeTimer`  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7405 [<samp>(03912)</samp>](vitest-dev/vitest@03912b43)-   Compat for jest-image-snapshot  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7390 [<samp>(9542b)</samp>](vitest-dev/vitest@9542b699)-   Ensure project names are readable in dark terminals  -  by [@&#8203;rgrove](https://github.com/rgrove) invitest-dev/vitest#7371 [<samp>(bb94c)</samp>](vitest-dev/vitest@bb94c19f)-   Exclude `queueMicrotask` from default fake timers to not break node fetch  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7505 [<samp>(167a9)</samp>](vitest-dev/vitest@167a98d7)-   **browser**:    -   Fix mocking modules out of root  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7415 [<samp>(d3acb)</samp>](vitest-dev/vitest@d3acbd8b)    -   Fix `toHaveClass` typing  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7383 [<samp>(7ef23)</samp>](vitest-dev/vitest@7ef238c0)    -   Relax locator selectors methods  -  by [@&#8203;sheremet-va](https://github.com/sheremet-va) invitest-dev/vitest#7422 [<samp>(1b8c5)</samp>](vitest-dev/vitest@1b8c5c9e)    -   Resolve thread count from `maxWorkers`  -  by [@&#8203;AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7483 [<samp>(adbb2)</samp>](vitest-dev/vitest@adbb25ab)    -   Cleanup timeout on resolve and give more information in the error  -  by [@&#8203;sheremet-va](https://github.com/sheremet-va) invitest-dev/vitest#7487 [<samp>(5a45a)</samp>](vitest-dev/vitest@5a45a7ca)-   **coverage**:    -   `vite-node` to pass correct execution wrapper offset  -  by [@&#8203;AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7417 [<samp>(1f2e5)</samp>](vitest-dev/vitest@1f2e5552)    -   Preserve moduleExecutionInfo in non-isolated runs  -  by [@&#8203;AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7486 [<samp>(f31a0)</samp>](vitest-dev/vitest@f31a07bb)-   **deps**:    -   Update all non-major dependencies  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7363 [<samp>(e348b)</samp>](vitest-dev/vitest@e348bd4c)    -   Update all non-major dependencies  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7507 [<samp>(6cc40)</samp>](vitest-dev/vitest@6cc408d6)-   **init**:    -   Invalid browser config  -  by [@&#8203;AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7475 [<samp>(8fe64)</samp>](vitest-dev/vitest@8fe641b4)-   **reporters**:    -   Render tasks in tree when in TTY  -  by [@&#8203;AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7503 [<samp>(027ce)</samp>](vitest-dev/vitest@027ce9bb)-   **vite-node**:    -   Remove fake first line mapping on Vite 6  -  by [@&#8203;hi-ogawa](https://github.com/hi-ogawa) invitest-dev/vitest#7124 [<samp>(b9973)</samp>](vitest-dev/vitest@b997355b)-   **watch**:    -   Properly remove cache after removing existing test files  -  by [@&#8203;soc221b](https://github.com/soc221b) invitest-dev/vitest#7399 [<samp>(01a59)</samp>](vitest-dev/vitest@01a59721)-   **workspace**:    -   Forward `inspect` related cli options  -  by [@&#8203;AriPerkkio](https://github.com/AriPerkkio) invitest-dev/vitest#7373 [<samp>(ed15b)</samp>](vitest-dev/vitest@ed15b5b3)#####     [View changes on GitHub](vitest-dev/vitest@v3.0.5...v3.0.6)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjQuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE2NC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->Reviewed-on:https://gitea.justinelmore.dev/jelmore1674/build-changelog/pulls/91Co-authored-by: Renovate Bot <renovate-bot@forgejo.justinelmore.dev>Co-committed-by: Renovate Bot <renovate-bot@forgejo.justinelmore.dev>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@VladyslavKochetkovVladyslavKochetkovVladyslavKochetkov left review comments

@sheremet-vasheremet-vasheremet-va approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toHaveClass has incorrect types when{ exact: true } is used
3 participants
@hi-ogawa@sheremet-va@VladyslavKochetkov

[8]ページ先頭

©2009-2025 Movatter.jp