Commitd31fdb7

authored

fix: detect expectations in chains with underscores (#607)

1 parent2abdad0 commitd31fdb7Copy full SHA for d31fdb7

File tree

+14

-5

lines changed

+14

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ function matchesAssertFunctionName(`
`22`	`22`	`.split('.')`
`23`	`23`	`.map((x)=>{`
`24`	`24`	`if(x==='**')`
`25`		`-return'[a-z\\d\\.]*'`
	`25`	`+return'[_a-z\\d\\.]*'`
`26`	`26`
`27`	`27`	`returnx.replace(/\/gu,'[a-z\\d]')`
`28`	`28`	`})`

Lines changed: 13 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`		`-import{AST_NODE_TYPES}from'@typescript-eslint/utils'`
`2`		`-importrule,{RULE_NAME}from'../src/rules/expect-expect'`
`3`		`-import{ruleTester}from'./ruleTester'`
	`1`	`+import{AST_NODE_TYPES}from'@typescript-eslint/utils';`
	`2`	`+`
	`3`	`+importrule,{RULE_NAME}from'../src/rules/expect-expect';`
	`4`	`+import{ruleTester}from'./ruleTester';`
`4`	`5`
`5`	`6`	`ruleTester.run(RULE_NAME,rule,{`
`6`	`7`	`valid:[`
`@@ -42,7 +43,15 @@ it('example', async () => {`
`42`	`43`	`const result = Promise.reject<string>('error');`
`43`	`44`
`44`	`45`	`await expect(result.then((it) => it.toUpperCase())).rejects.toThrow();`
`45`		-});`
	`46`	+});`,
	`47`	`+{`
	`48`	+code:`it("should pass", () => { anyChain.of.calls.expect(true) })`,
	`49`	`+options:[{assertFunctionNames:['**.expect']}]`
	`50`	`+},`
	`51`	`+{`
	`52`	+code:`it("should pass", () => { any_chain.of.calls.expect(true) })`,
	`53`	`+options:[{assertFunctionNames:['**.expect']}]`
	`54`	`+}`
`46`	`55`	`],`
`47`	`56`	`invalid:[`
`48`	`57`	`{`

Comments

(0)