Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Turbopack] improve task optimization#74837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sokra merged 3 commits intocanaryfromsokra/optimize-based-on-follower
Jan 15, 2025

Conversation

sokra
Copy link
Member

@sokrasokra commentedJan 13, 2025•
edited by padmaia
Loading

What?

improves the heuristic for task optimization.

It minimizes the produce of(uppers - 1) * follower and chooses a bigger aggregation number based on that.

This allows for many uppers when there are no followers. That is often the case when a task is shared between multiple pages. Or for tasks are are near the leafs of the graph.

ClosesPACK-3728

8153764 reacted with eyes emoji
@sokraGraphite App
Copy link
MemberAuthor

sokra commentedJan 13, 2025•
edited
Loading

@sokrasokra changed the titleskip optimization without follower[Turbopack] improve task optimizationJan 13, 2025
@sokrasokra marked this pull request as ready for reviewJanuary 13, 2025 21:19
@sokrasokra requested a review frommischnicJanuary 13, 2025 21:21
@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch frombf2e392 toc426bbeCompareJanuary 13, 2025 21:31
@ijjk
Copy link
Member

ijjk commentedJan 13, 2025•
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
buildDuration18.1s15.1sN/A
buildDurationCached14.2s11.9sN/A
nodeModulesSize418 MB418 MBN/A
nextStartRea..uration (ms)416ms414msN/A
Client Bundles (main, webpack)
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
5306-HASH.js gzip53.9 kB53.9 kBN/A
8276.HASH.js gzip169 B168 BN/A
8377-HASH.js gzip5.44 kB5.44 kBN/A
bccd1874-HASH.js gzip52.9 kB52.9 kBN/A
framework-HASH.js gzip57.5 kB57.5 kBN/A
main-app-HASH.js gzip241 B242 BN/A
main-HASH.js gzip34.2 kB34.2 kBN/A
webpack-HASH.js gzip1.71 kB1.71 kBN/A
Overall change0 B0 B✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
polyfills-HASH.js gzip39.4 kB39.4 kB✓
Overall change39.4 kB39.4 kB✓
Client Pages
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
_app-HASH.js gzip193 B193 B✓
_error-HASH.js gzip193 B193 B✓
amp-HASH.js gzip512 B510 BN/A
css-HASH.js gzip343 B342 BN/A
dynamic-HASH.js gzip1.84 kB1.84 kB✓
edge-ssr-HASH.js gzip265 B265 B✓
head-HASH.js gzip363 B362 BN/A
hooks-HASH.js gzip393 B392 BN/A
image-HASH.js gzip4.57 kB4.57 kBN/A
index-HASH.js gzip268 B268 B✓
link-HASH.js gzip2.35 kB2.34 kBN/A
routerDirect..HASH.js gzip328 B328 B✓
script-HASH.js gzip397 B397 B✓
withRouter-HASH.js gzip323 B326 BN/A
1afbb74e6ecf..834.css gzip106 B106 B✓
Overall change3.59 kB3.59 kB✓
Client Build Manifests
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
_buildManifest.js gzip749 B747 BN/A
Overall change0 B0 B✓
Rendered Page Sizes
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
index.html gzip524 B524 B✓
link.html gzip539 B538 BN/A
withRouter.html gzip520 B520 B✓
Overall change1.04 kB1.04 kB✓
Edge SSR bundle Size
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
edge-ssr.js gzip129 kB129 kBN/A
page.js gzip208 kB208 kBN/A
Overall change0 B0 B✓
Middleware size
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
middleware-b..fest.js gzip668 B667 BN/A
middleware-r..fest.js gzip155 B156 BN/A
middleware.js gzip31.3 kB31.3 kBN/A
edge-runtime..pack.js gzip844 B844 B✓
Overall change844 B844 B✓
Next Runtimes
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
274-experime...dev.js gzip322 B322 B✓
274.runtime.dev.js gzip314 B314 B✓
app-page-exp...dev.js gzip374 kB374 kB✓
app-page-exp..prod.js gzip130 kB130 kB✓
app-page-tur..prod.js gzip143 kB143 kB✓
app-page-tur..prod.js gzip139 kB139 kB✓
app-page.run...dev.js gzip362 kB362 kB✓
app-page.run..prod.js gzip126 kB126 kB✓
app-route-ex...dev.js gzip37.6 kB37.6 kB✓
app-route-ex..prod.js gzip25.6 kB25.6 kB✓
app-route-tu..prod.js gzip25.6 kB25.6 kB✓
app-route-tu..prod.js gzip25.4 kB25.4 kB✓
app-route.ru...dev.js gzip39.2 kB39.2 kB✓
app-route.ru..prod.js gzip25.4 kB25.4 kB✓
pages-api-tu..prod.js gzip9.69 kB9.69 kB✓
pages-api.ru...dev.js gzip11.6 kB11.6 kB✓
pages-api.ru..prod.js gzip9.68 kB9.68 kB✓
pages-turbo...prod.js gzip21.7 kB21.7 kB✓
pages.runtim...dev.js gzip27.5 kB27.5 kB✓
pages.runtim..prod.js gzip21.7 kB21.7 kB✓
server.runti..prod.js gzip916 kB916 kB✓
Overall change2.47 MB2.47 MB✓
build cache
vercel/next.js canaryvercel/next.js sokra/optimize-based-on-followerChange
0.pack gzip2.1 MB2.09 MBN/A
index.pack gzip75.4 kB74.7 kBN/A
Overall change0 B0 B✓
Diff details
Diff formain-HASH.js

Diff too large to display

Commit:d8f6879

@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch fromc426bbe toec34acaCompareJanuary 14, 2025 12:52
@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch fromec34aca tob79e958CompareJanuary 14, 2025 13:20
@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch fromb79e958 tod6920e7CompareJanuary 14, 2025 13:32
@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch fromd6920e7 toef20e03CompareJanuary 14, 2025 15:23
@sokrasokraforce-pushed thesokra/lazy-connect branch 2 times, most recently from09299b0 to118a2afCompareJanuary 14, 2025 15:40
@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch 2 times, most recently from366f31b to1c82c34CompareJanuary 14, 2025 22:55
@ijjkijjk added create-next-appRelated to our CLI tool for quickly starting a new Next.js application. tests type: next labelsJan 14, 2025
@sokrasokra changed the base branch fromsokra/lazy-connect tocanaryJanuary 14, 2025 22:55
@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch from1c82c34 tocecc470CompareJanuary 15, 2025 06:08
@sokrasokra changed the base branch fromcanary tosokra/remove-children-countJanuary 15, 2025 06:08
@sokrasokra changed the base branch fromsokra/remove-children-count tographite-base/74837January 15, 2025 06:45
@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch fromcecc470 to32115b0CompareJanuary 15, 2025 06:46
@sokrasokra changed the base branch fromgraphite-base/74837 tocanaryJanuary 15, 2025 06:46
@sokrasokraforce-pushed thesokra/optimize-based-on-follower branch from32115b0 tod8f6879CompareJanuary 15, 2025 06:46
@sokrasokra merged commit2f4610e intocanaryJan 15, 2025
132 checks passed
@sokraGraphite App
Copy link
MemberAuthor

Merge activity

  • Jan 15, 2:19 AM EST: A user merged this pull request withGraphite.

@sokrasokra deleted the sokra/optimize-based-on-follower branchJanuary 15, 2025 07:19
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mischnicmischnicmischnic approved these changes

Assignees
No one assigned
Labels
create-next-appRelated to our CLI tool for quickly starting a new Next.js application.created-by: Turbopack teamPRs by the Turbopack team.lockedteststype: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sokra@ijjk@mischnic
[8]ページ先頭
©2009-2025 Movatter.jp