Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DevOverlay] Add Runtime Error CodeFrame#74682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
devjiwonchoi merged 7 commits intocanaryfrom01-09-_devoverlay_add_codeframe
Jan 10, 2025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoidevjiwonchoi commentedJan 9, 2025•
edited
Loading

This PR added style for Runtime Error Code Frame. The file icon will follow up and will be replaced with correct icons (e.g. js, ts, etc.)

Note

Does not fully align with Figma due to restrictions on how@babel/code-frame handles colors and spacing.

Light

CleanShot 2025-01-10 at 23 15 52

Dark

CleanShot 2025-01-10 at 23 16 22

ClosesNDX-650

@devjiwonchoiGraphite App
Copy link
MemberAuthor

devjiwonchoi commentedJan 9, 2025•
edited
Loading

@ijjk
Copy link
Member

ijjk commentedJan 9, 2025•
edited
Loading

Stats from current PR

Default Build (Increase detected⚠️)
General Overall increase⚠️
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
buildDuration43.3s40.3sN/A
buildDurationCached38.5s32.5sN/A
nodeModulesSize417 MB417 MB⚠️ +175 kB
nextStartRea..uration (ms)1s1.1sN/A
Client Bundles (main, webpack)
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
5306-HASH.js gzip53.3 kB53.3 kBN/A
8276.HASH.js gzip169 B168 BN/A
8377-HASH.js gzip5.44 kB5.44 kBN/A
bccd1874-HASH.js gzip53 kB53 kB✓
framework-HASH.js gzip57.5 kB57.5 kBN/A
main-app-HASH.js gzip241 B243 BN/A
main-HASH.js gzip34.1 kB34.1 kBN/A
webpack-HASH.js gzip1.71 kB1.71 kBN/A
Overall change53 kB53 kB✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
polyfills-HASH.js gzip39.4 kB39.4 kB✓
Overall change39.4 kB39.4 kB✓
Client Pages
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
_app-HASH.js gzip193 B193 B✓
_error-HASH.js gzip193 B193 B✓
amp-HASH.js gzip512 B510 BN/A
css-HASH.js gzip343 B342 BN/A
dynamic-HASH.js gzip1.84 kB1.84 kB✓
edge-ssr-HASH.js gzip265 B265 B✓
head-HASH.js gzip363 B362 BN/A
hooks-HASH.js gzip393 B392 BN/A
image-HASH.js gzip4.57 kB4.57 kBN/A
index-HASH.js gzip268 B268 B✓
link-HASH.js gzip2.35 kB2.34 kBN/A
routerDirect..HASH.js gzip328 B328 B✓
script-HASH.js gzip397 B397 B✓
withRouter-HASH.js gzip323 B326 BN/A
1afbb74e6ecf..834.css gzip106 B106 B✓
Overall change3.59 kB3.59 kB✓
Client Build Manifests
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
_buildManifest.js gzip749 B747 BN/A
Overall change0 B0 B✓
Rendered Page Sizes
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
index.html gzip522 B521 BN/A
link.html gzip538 B535 BN/A
withRouter.html gzip518 B518 B✓
Overall change518 B518 B✓
Edge SSR bundle Size
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
edge-ssr.js gzip128 kB128 kBN/A
page.js gzip207 kB207 kBN/A
Overall change0 B0 B✓
Middleware size
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
middleware-b..fest.js gzip671 B667 BN/A
middleware-r..fest.js gzip155 B156 BN/A
middleware.js gzip31.2 kB31.2 kBN/A
edge-runtime..pack.js gzip844 B844 B✓
Overall change844 B844 B✓
Next Runtimes Overall increase⚠️
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
274-experime...dev.js gzip322 B322 B✓
274.runtime.dev.js gzip314 B314 B✓
app-page-exp...dev.js gzip368 kB369 kB⚠️ +1.09 kB
app-page-exp..prod.js gzip129 kB129 kB✓
app-page-tur..prod.js gzip142 kB142 kB✓
app-page-tur..prod.js gzip138 kB138 kB✓
app-page.run...dev.js gzip356 kB357 kB⚠️ +1.11 kB
app-page.run..prod.js gzip126 kB126 kB✓
app-route-ex...dev.js gzip37.6 kB37.6 kB✓
app-route-ex..prod.js gzip25.6 kB25.6 kB✓
app-route-tu..prod.js gzip25.6 kB25.6 kB✓
app-route-tu..prod.js gzip25.4 kB25.4 kB✓
app-route.ru...dev.js gzip39.2 kB39.2 kB✓
app-route.ru..prod.js gzip25.4 kB25.4 kB✓
pages-api-tu..prod.js gzip9.69 kB9.69 kB✓
pages-api.ru...dev.js gzip11.6 kB11.6 kB✓
pages-api.ru..prod.js gzip9.68 kB9.68 kB✓
pages-turbo...prod.js gzip21.7 kB21.7 kB✓
pages.runtim...dev.js gzip27.5 kB27.5 kB✓
pages.runtim..prod.js gzip21.7 kB21.7 kB✓
server.runti..prod.js gzip916 kB916 kB✓
Overall change2.46 MB2.46 MB⚠️ +2.2 kB
build cache Overall increase⚠️
vercel/next.js canaryvercel/next.js 01-09-_devoverlay_add_codeframeChange
0.pack gzip2.09 MB2.09 MB⚠️ +651 B
index.pack gzip76.1 kB74.4 kBN/A
Overall change2.09 MB2.09 MB⚠️ +651 B
Diff details
Diff formain-HASH.js

Diff too large to display

Diff forapp-page-exp..ntime.dev.js
failed to diff
Diff forapp-page.runtime.dev.js
failed to diff
Commit:d6185d8

@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch from95a41b2 tobaab20cCompareJanuary 9, 2025 09:41
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch from11b99f0 toa8c2b5dCompareJanuary 9, 2025 09:41
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch frombaab20c to5e65707CompareJanuary 9, 2025 13:29
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch froma8c2b5d toc9b03b0CompareJanuary 9, 2025 13:29
@ijjk
Copy link
Member

ijjk commentedJan 9, 2025•
edited
Loading

Failing test suites

Commit:d6185d8

pnpm test test/integration/clean-distdir/test/index.test.js

  • Cleaning distDir > production mode > should clean up .next before build start
Expand output

● Cleaning distDir › production mode › should clean up .next before build start

thrown: "Exceeded timeout of 60000 ms for a test.Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."  25 |  26 | const runTests = () => {> 27 |   it('should clean up .next before build start', async () => {     |   ^  28 |     await checkFileWrite(false)  29 |   })  30 | }  at it (integration/clean-distdir/test/index.test.js:27:3)  at runTests (integration/clean-distdir/test/index.test.js:40:7)  at integration/clean-distdir/test/index.test.js:33:56  at Object.describe (integration/clean-distdir/test/index.test.js:32:1)

Read more about building and testing Next.js incontributing.md.

@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch from5e65707 to80f0b0fCompareJanuary 9, 2025 15:46
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch from91e9373 tob0031dfCompareJanuary 9, 2025 15:46
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch from80f0b0f to6f128a6CompareJanuary 10, 2025 06:56
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch from889970d to76d4b38CompareJanuary 10, 2025 06:56
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch from6f128a6 to55a52d7CompareJanuary 10, 2025 08:13
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch from76d4b38 to4f46bfbCompareJanuary 10, 2025 08:14
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch from55a52d7 to2bd7bf5CompareJanuary 10, 2025 08:38
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch from4f46bfb to6b23a14CompareJanuary 10, 2025 08:38
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch from2bd7bf5 to1742596CompareJanuary 10, 2025 08:44
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch from688ad03 to9fb7bf1CompareJanuary 10, 2025 08:44
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch fromb7b2ed4 to97035d8CompareJanuary 10, 2025 14:24
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch fromf6d752a to65ca28eCompareJanuary 10, 2025 14:24
@devjiwonchoidevjiwonchoi changed the title[DevOverlay] Add CodeFrame[DevOverlay] Add Runtime Error CodeFrameJan 10, 2025
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch from97035d8 to380425cCompareJanuary 10, 2025 14:41
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch from65ca28e to4a63268CompareJanuary 10, 2025 14:41
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_call_stack branch from39f416b toff163dfCompareJanuary 10, 2025 15:56
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch from4a63268 tocf6f4f9CompareJanuary 10, 2025 15:56
Copy link
Member

@eps1loneps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

does the yellow on white (e.g. onnew Error() fulfill AAA contrast ratio (seehttps://webaim.org/resources/contrastchecker/#:~:text=WCAG%20Level%20AAA%20requires%20a,4.5%3A1%20for%20large%20text.)?

Feels like it's not.

@devjiwonchoidevjiwonchoi changed the base branch from01-09-_devoverlay_add_call_stack tographite-base/74682January 10, 2025 17:11
@devjiwonchoidevjiwonchoiforce-pushed the01-09-_devoverlay_add_codeframe branch fromd6185d8 to65046bcCompareJanuary 10, 2025 17:13
@devjiwonchoidevjiwonchoi changed the base branch fromgraphite-base/74682 tocanaryJanuary 10, 2025 17:14
@graphite-appGraphite App
Copy link
Contributor

Merge activity

  • Jan 10, 12:14 PM EST:Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@devjiwonchoi
Copy link
MemberAuthor

does the yellow on white (e.g. on new Error() fulfill AAA contrast ratio

Great point, yeah it doesn't pass. Will follow up.

@devjiwonchoidevjiwonchoi merged commit6c52257 intocanaryJan 10, 2025
33 of 38 checks passed
@devjiwonchoidevjiwonchoi deleted the 01-09-_devoverlay_add_codeframe branchJanuary 10, 2025 17:33
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@huozhihuozhihuozhi approved these changes

@eps1loneps1loneps1lon approved these changes

@gaojudegaojudeAwaiting requested review from gaojude

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@devjiwonchoi@ijjk@huozhi@eps1lon
[8]ページ先頭
©2009-2025 Movatter.jp