Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DevOverlay] Remove Dialog Banner#74464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoidevjiwonchoi commentedJan 2, 2025•
edited
Loading

This PR removed the Dialog Banner as it is removed in the renewal design.

CleanShot 2025-01-02 at 22.04.02.png

@ijjkijjk added created-by: Next.js teamPRs by the Next.js team. type: next labelsJan 2, 2025
@ijjk
Copy link
Member

ijjk commentedJan 2, 2025•
edited
Loading

Stats from current PR

Default Build (Increase detected⚠️)
General Overall increase⚠️
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
buildDuration46.2s43sN/A
buildDurationCached44.7s34.8sN/A
nodeModulesSize416 MB416 MBN/A
nextStartRea..uration (ms)954ms1.1s⚠️ +186ms
Client Bundles (main, webpack)
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
1187-HASH.js gzip52.4 kB52.4 kBN/A
8276.HASH.js gzip169 B168 BN/A
8377-HASH.js gzip5.36 kB5.36 kBN/A
bccd1874-HASH.js gzip52.8 kB52.8 kBN/A
framework-HASH.js gzip57.5 kB57.5 kBN/A
main-app-HASH.js gzip232 B235 BN/A
main-HASH.js gzip34.1 kB34.1 kBN/A
webpack-HASH.js gzip1.71 kB1.71 kBN/A
Overall change0 B0 B✓
Legacy Client Bundles (polyfills)
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
polyfills-HASH.js gzip39.4 kB39.4 kB✓
Overall change39.4 kB39.4 kB✓
Client Pages
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
_app-HASH.js gzip193 B193 B✓
_error-HASH.js gzip193 B193 B✓
amp-HASH.js gzip512 B510 BN/A
css-HASH.js gzip343 B342 BN/A
dynamic-HASH.js gzip1.84 kB1.84 kB✓
edge-ssr-HASH.js gzip265 B265 B✓
head-HASH.js gzip363 B362 BN/A
hooks-HASH.js gzip393 B392 BN/A
image-HASH.js gzip4.49 kB4.49 kBN/A
index-HASH.js gzip268 B268 B✓
link-HASH.js gzip2.35 kB2.34 kBN/A
routerDirect..HASH.js gzip328 B328 B✓
script-HASH.js gzip397 B397 B✓
withRouter-HASH.js gzip323 B326 BN/A
1afbb74e6ecf..834.css gzip106 B106 B✓
Overall change3.59 kB3.59 kB✓
Client Build Manifests
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
_buildManifest.js gzip749 B746 BN/A
Overall change0 B0 B✓
Rendered Page Sizes
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
index.html gzip524 B522 BN/A
link.html gzip538 B536 BN/A
withRouter.html gzip520 B519 BN/A
Overall change0 B0 B✓
Edge SSR bundle Size
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
edge-ssr.js gzip128 kB128 kBN/A
page.js gzip206 kB206 kBN/A
Overall change0 B0 B✓
Middleware size
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
middleware-b..fest.js gzip669 B665 BN/A
middleware-r..fest.js gzip155 B156 BN/A
middleware.js gzip31.2 kB31.2 kBN/A
edge-runtime..pack.js gzip844 B844 B✓
Overall change844 B844 B✓
Next Runtimes
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
274-experime...dev.js gzip322 B322 B✓
274.runtime.dev.js gzip314 B314 B✓
app-page-exp...dev.js gzip359 kB359 kBN/A
app-page-exp..prod.js gzip129 kB129 kB✓
app-page-tur..prod.js gzip142 kB142 kB✓
app-page-tur..prod.js gzip137 kB137 kB✓
app-page.run...dev.js gzip348 kB348 kBN/A
app-page.run..prod.js gzip125 kB125 kB✓
app-route-ex...dev.js gzip37.5 kB37.5 kB✓
app-route-ex..prod.js gzip25.5 kB25.5 kB✓
app-route-tu..prod.js gzip25.5 kB25.5 kB✓
app-route-tu..prod.js gzip25.4 kB25.4 kB✓
app-route.ru...dev.js gzip39.2 kB39.2 kB✓
app-route.ru..prod.js gzip25.4 kB25.4 kB✓
pages-api-tu..prod.js gzip9.69 kB9.69 kB✓
pages-api.ru...dev.js gzip11.6 kB11.6 kB✓
pages-api.ru..prod.js gzip9.68 kB9.68 kB✓
pages-turbo...prod.js gzip21.7 kB21.7 kB✓
pages.runtim...dev.js gzip27.5 kB27.5 kB✓
pages.runtim..prod.js gzip21.7 kB21.7 kB✓
server.runti..prod.js gzip916 kB916 kB✓
Overall change1.73 MB1.73 MB✓
build cache Overall increase⚠️
vercel/next.js canaryvercel/next.js 01-02-_devoverlay_remove_dialog_bannerChange
0.pack gzip2.09 MB2.09 MBN/A
index.pack gzip74.1 kB74.5 kB⚠️ +339 B
Overall change74.1 kB74.5 kB⚠️ +339 B
Diff details
Diff formain-HASH.js

Diff too large to display

Diff forapp-page-exp..ntime.dev.js
failed to diff
Diff forapp-page.runtime.dev.js
failed to diff
Commit:418f191

@devjiwonchoiGraphite App
Copy link
MemberAuthor

devjiwonchoi commentedJan 3, 2025•
edited
Loading

Merge activity

  • Jan 3, 7:07 AM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Jan 3, 7:07 AM EST: A user merged this pull request withGraphite.

@devjiwonchoidevjiwonchoi merged commite0022d5 intocanaryJan 3, 2025
132 checks passed
@devjiwonchoidevjiwonchoi deleted the 01-02-_devoverlay_remove_dialog_banner branchJanuary 3, 2025 12:07
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ijjkijjkijjk approved these changes

@gaojudegaojudegaojude approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@devjiwonchoi@ijjk@gaojude
[8]ページ先頭
©2009-2025 Movatter.jp