NotificationsYou must be signed in to change notification settings
Fork30.1k
Star137k

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.

base repository:vercel/next.js

Failed to load repositories. Confirm that selected base ref is valid, then try again.

base:v14.2.12

Choose a base ref

...

head repository:vercel/next.js

Failed to load repositories. Confirm that selected head ref is valid, then try again.

compare:v14.2.13

Choose a head ref

5commits
29files changed
5contributors

Commits on Sep 19, 2024

Fix missing cache-control on SSR app route (#70265 )

This removes an inaccurate check that doesn't set a revalidate value ifrevalidate is `undefined` which can be the case for SSR app route pages.Also adds a regression test to ensure this doesn't break again.Fixes:#70213# Conflicts:#packages/next/src/server/base-server.ts

ijjk committedSep 19, 2024

Configuration menu

Copy the full SHA

b503b8e

View commit details

Browse the repository at this point in the history

feat: add polyfill ofURL.canParsefor browser compatibility (#70228 )

### Why?Since `URL.canParse` is incompatible with older browsers like Safari 16,we added `canParseUrl` util at#70215.x-ref:https://caniuse.com/?search=URL.canParseTo improve maintenance, we decided to add polyfill for `URL.canParse`.x-ref: [slackthread](https://vercel.slack.com/archives/C07BVA6HM17/p1726664071636899?thread_ts=1726620161.450109&cid=C07BVA6HM17)ClosesNDX-302---------Co-authored-by: Jiachi Liu <inbox@huozhi.im># Conflicts:#packages/next/src/lib/url.ts#packages/next/src/server/lib/router-server.ts#pnpm-lock.yaml

2 people authored andijjk committedSep 19, 2024

Configuration menu

Copy the full SHA

62fbd7f

View commit details

Browse the repository at this point in the history

Fix vercel og package memory leak (#70214 )
```
# Conflicts:#pnpm-lock.yaml
```
huozhi authored andijjk committedSep 19, 2024
Configuration menu
View commit details
Copy full SHA for 49566f5
Browse repository at this point
Copy the full SHA
49566f5View commit details
Browse the repository at this point in the history

Fix startTime error on Android 9 with Chrome 74 (#67391 )

### What?Fixes the error `Cannot read property 'startTime' of null` on Chrome 74for Android 9 by ensuring the `beforeHydrationMeasure` and`hydrationMeasure` are not falsy values before accessing theirproperties.<img width="1164" alt="Screenshot 2024-07-02 at 11 14 53 PM"src="https://github.com/vercel/next.js/assets/52588326/34df95b6-a4fe-4886-96b8-a3c873a2ae6a">### Why?The application crashes on Chrome 74 for Android 9 due to `null` orother falsy values being returned in certain situations. This fixensures that the `startTime` property is only accessed if it is not afalsy value, thereby preventing the crash.### How?Added a falsy check before accessing the `startTime` property in theperformance measurement logic. Specifically, modified the code at [thislocation](https://github.com/vercel/next.js/blob/b9bd23baec14508400c502b3651f4cf2497e883b/packages/next/src/client/index.tsx#L498)Co-authored-by: JJ Kasper <jj@jjsweb.site>