Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Passstart command required in Solr 10#10174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@epugh
Copy link
Contributor

In 10x we removed the short cut that "bin/solr" was a call to "bin/solr start", now we require you to specify what subcommand you want. This change is backwards compatible with 8x and 9x, and forwards compatible with the upcoming Solr 10 release.

@epughepugh requested a review froma teamApril 7, 2025 10:49
@eddumelendez
Copy link
Member

Hi@epugh, thanks for your contribution. Do you mind adding a test with version 10.x?

@epugh
Copy link
ContributorAuthor

Hi@epugh, thanks for your contribution. Do you mind adding a test with version 10.x?

10x hasn't yet been released (sometime in May to June-ish timeframe) so I don't think I can add the test. Having said that, I'll definitly provide a test when we have a release available.

The addition of the word "start" is compatible with 8 and 9, and will be required in 10.

@eddumelendezeddumelendez changed the titlein Solr 10 we require you to explicitly pass in the "start" commandPassstart command required in Solr 10Apr 7, 2025
@eddumelendezeddumelendez merged commit80ae5d7 intotestcontainers:mainApr 7, 2025
106 checks passed
@eddumelendezeddumelendez added this to thenext milestoneApr 7, 2025
@eddumelendez
Copy link
Member

Thanks again for your contribution,@epugh! Glad to see those changes are backward compatible and will make the module ready to support the upcoming Solr version.

@epugh
Copy link
ContributorAuthor

My pleasure! I apprecaite your comments, and it made it a pleasant experience to contribute ;-)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

2 participants

@epugh@eddumelendez

[8]ページ先頭

©2009-2025 Movatter.jp