- Notifications
You must be signed in to change notification settings - Fork35
Add PromiseCapability wrapper around sync dispose used in anawait using#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
A preview of this PR can be found athttps://tc39.es/proposal-explicit-resource-management/pr/218. |
This was referencedMar 22, 2024
syg approved these changesApr 5, 2024
syg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Editorially lgtm.
ljharb added a commit to es-shims/DisposableStack that referenced this pull requestApr 10, 2024
7 tasks
zloirock added a commit to zloirock/core-js that referenced this pull requestJan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
bugSomething isn't working has-consensusIndicates a pull request reached consensus at TC39 plenary. needs-consensusA pull request that needs consensus at TC39 plenary normativeIndicates a normative change to the specification
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in#216 (comment), this adds a
PromiseCapabilityto the wrapper function created around a@@disposemethod read by anawait usingdeclaration to ensure that any errors thrown by@@disposeare not thrown synchronously. This is in keeping with the mechanism used in%AsyncFromSyncIteratorPrototype%.next().