Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.6k
Use@layer properties
for@property
polyfills#17506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
96240eb
to1aa6fb4
Compare1aa6fb4
to7fe08e8
CompareRobinMalfait approved these changesApr 2, 2025
4484192
intomain 7 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR changes how polyfills for
@property
are inserted. The main motivation is to remove the need to rely on the correct placement of@layer base;
—Something that's not really required right not in Tailwind CSS v4 and we'd like to keep it this way.The idea is that the polyfills are inserted for you automatically. To ensure they always take precedence, we insert an empty
@layer properties;
at the top of the CSS file so that later, when we emit all@property
rules and their fallback, we can use this new named layer to ensure the rules have a higher order.Unfortunately, just putting
@layer properties;
at the beginning of a file would not work aslightningcss
incorrectly hoists all content into the first occurrence of a layer name meaning these rules might be insertedbefore eventual external imports:To work around this, we have to insert that layer name after any eventual remaining external
@imports
for now.Test plan