Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

perf(es/lexer): Reduce allocations while lexing numbers#10667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kdy1 merged 2 commits intoswc-project:mainfrombvanjoi:pref-read-number
Jun 21, 2025

Conversation

bvanjoi
Copy link
Contributor

No description provided.

@bvanjoibvanjoi requested a review froma team as acode ownerJune 21, 2025 12:18
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJun 21, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:668f15a

The changes in this PR will be included in the next version bump.

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bvanjoi
Copy link
ContributorAuthor

bvanjoi commentedJun 21, 2025•
edited
Loading

I've found optimization patterns similar to those implemented in#10655. Let's verify this by comparing benchmark results.

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedJun 21, 2025•
edited
Loading

CodSpeed Performance Report

Merging#10667 willdegrade performances by 6.73%

Comparingbvanjoi:pref-read-number (668f15a) withmain (5f4f7dd)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 137 untouched benchmarks

⚠️Please fix the performance issues oracknowledge them on CodSpeed.

Benchmarks breakdown

BenchmarkBASEHEADChange
⚡es/lexer/colors40.9 µs39.9 µs+2.59%
❌es2020_nullish_coalescing287 µs307.7 µs-6.73%
⚡es/target/es20151.3 ms1.2 ms+2.45%

@bvanjoi
Copy link
ContributorAuthor

The benchmark indicates this implementation acceptable.

@kdy1kdy1 added this to thePlanned milestoneJun 21, 2025
@kdy1kdy1 requested a review froma team as acode ownerJune 21, 2025 18:15
@kdy1kdy1 changed the titleperf(swc/lexer): less alloc in read numperf(es/lexer): Reduce allocations while lexing numbersJun 21, 2025
@kdy1kdy1 merged commit115d228 intoswc-project:mainJun 21, 2025
32 checks passed
@kdy1kdy1 modified the milestones:Planned,v1.12.6Jun 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kdy1kdy1kdy1 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
v1.12.6
Development

Successfully merging this pull request may close these issues.

2 participants
@bvanjoi@kdy1
[8]ページ先頭
©2009-2025 Movatter.jp