Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

perf(es/minifier): Limit infection analysis by the entry size#10006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kdy1 merged 10 commits intoswc-project:mainfromkdy1:minifier-infects
Feb 6, 2025

Conversation

kdy1
Copy link
Member

@kdy1kdy1 commentedFeb 6, 2025

Description:

In most real-world inputs, many infected identifiers typically mean we can't optimize it anyway. Because of the variable usage analysis result of the infected variable, we can't do any optimization to the original variable in most cases. So this PR stops the infection analyzer at a specific threshold.

Related issue:

@kdy1kdy1 added this to thePlanned milestoneFeb 6, 2025
@kdy1kdy1 requested a review froma team as acode ownerFebruary 6, 2025 19:16
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedFeb 6, 2025
edited
Loading

🦋 Changeset detected

Latest commit:42557a0

The changes in this PR will be included in the next version bump.

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhqbot previously approved these changesFeb 6, 2025
@kdy1kdy1enabled auto-merge (squash)February 6, 2025 19:16
@kdy1kdy1 merged commit1a3a4b9 intoswc-project:mainFeb 6, 2025
170 checks passed
@kdy1kdy1 deleted the minifier-infects branchFebruary 6, 2025 19:46
kdy1 added a commit to kdy1/swc that referenced this pull requestFeb 6, 2025
kdy1 added a commit that referenced this pull requestFeb 6, 2025
**Description:**Invert#10006 because the analyzer should not give up analyzing the aliases because it uses the aliasing information to modify the `VarUsageInfo` of aliases.
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedFeb 7, 2025
edited
Loading

CodSpeed Performance Report

Merging#10006 willimprove performances by 7.91%

Comparingkdy1:minifier-infects (42557a0) withmain (4a90e51)

Summary

⚡ 3 improvements
✅ 193 untouched benchmarks

Benchmarks breakdown

BenchmarkBASEHEADChange
es/full/minify/libraries/lodash236.1 ms220.4 ms+7.15%
es/minifier/libs/lodash197.6 ms183.1 ms+7.91%
es/minifier/libs/vue234.7 ms225 ms+4.3%

@kdy1kdy1 modified the milestones:Planned,v1.10.15Feb 8, 2025
@swc-projectswc-project locked asresolvedand limited conversation to collaboratorsMar 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kodiakhqkodiakhq[bot]kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.10.15
Development

Successfully merging this pull request may close these issues.

es/minifier: Infection collector should have skipping logic based on the size of hash map
1 participant
@kdy1

[8]ページ先頭

©2009-2025 Movatter.jp