Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.7k
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:sveltejs/svelte
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:svelte@5.43.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:sveltejs/svelte
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:svelte@5.43.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 2commits
- 14files changed
- 4contributors
Commits on Nov 6, 2025
chore: remove
UNOWNEDflag (#17105)Fixes#17024Fixes#17049 (comment) (and therefore everything that was still buggy in that issue I think)* chore: remove unowned check when calling `e.effect_in_unowned_derived`* WIP* all non-unit tests passing* tidy* WIP* WIP* WIP* note to self* fix* fix* hmm maybe not* try this* simplify* remove skip_reaction* docs* add changeset, in case this results in changed behaviour* Update packages/svelte/src/internal/client/reactivity/effects.jsCo-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>*fix#17024* fix comment* revert* fix* dry* changeset* fix WAS_MARKED logic* failing test (that uncovered other unrelated bug) + fix* fix: delete from batch_values on updates (#17115)* fix: delete from batch_values on updatesThis fixes a bug where a derived would still show its old value even after it was indirectly updated again within the same batch. This can for example happen by reading a derived on an effect, then writing to a source in that same effect that makes the derived update, and then read the derived value in a sibling effect - it still shows the old value without the fix.The fix is to _delete_ the value from batch_values, as it's now the newest value across all batches. In order to not prevent breakage on other batches we have to leave the status of deriveds as-is, i.e. within is_dirty and update_derived we cannot update its status. That might be a bit more inefficient as you now have to traverse the graph for each `get` of that derived (it's a bit like they are all disconnected) but we can always optimize that later if need be.Another advantage of this fix is that we can get rid of duplicate logic we had to add about unmarking and reconnecting deriveds, because that logic was only needed for the case where deriveds are read after they are updated, which now no longer hits that if-branch* keep derived cache, but clear it in mark_reactions (#17116)---------Co-authored-by: Rich Harris <rich.harris@vercel.com>Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff svelte@5.43.3...svelte@5.43.4
Uh oh!
There was an error while loading.Please reload this page.