Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Addat-rule-no-unknown support forlanguageOptions#8475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ryo-manba merged 2 commits intomainfromissue-8453
Mar 17, 2025
Merged

Conversation

ryo-manba
Copy link
Member

@ryo-manbaryo-manba commentedMar 16, 2025•
edited
Loading

Which issue, if any, is this issue related to?

Closes#8453

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

This is slightly off-topic, but I created an issue because tests currently only supportstandalone.
It would be better iflanguageOptions could be configured per rule.

stylelint/jest-preset-stylelint#143

jeddy3 and mizdra reacted with thumbs up emoji
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedMar 16, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:00126e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
stylelintMinor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedMar 16, 2025•
edited
Loading

Try the Instant Preview in Online Demo

Stylelint Online Demo

Install the Instant Preview to Your Local

npm i -D https://pkg.pr.new/stylelint@8475

View Commit

Copy link
Member

@jeddy3jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, nicely done thank you.

ryo-manba reacted with heart emoji
Copy link
Member

@ybiquitousybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've left a few notes, but they're not blockers. LGTM 👍🏼

ryo-manba reacted with heart emoji
@ryo-manbaryo-manba merged commit017aff1 intomainMar 17, 2025
19 checks passed
@ryo-manbaryo-manba deleted the issue-8453 branchMarch 17, 2025 13:26
@@ -37,13 +37,20 @@ const rule = (primary, secondaryOptions) => {
return;
}

const languageAtRules = result.stylelint.config?.languageOptions?.syntax?.atRules || {};
const configuredAtRuleNames = new Set(Object.keys(languageAtRules));

root.walkAtRules((atRule) => {
if (!isStandardSyntaxAtRule(atRule)) {
return;
}

const name = atRule.name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

question

IsatRule.name always lowercased?

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestMar 28, 2025
| datasource | package   | from    | to      || ---------- | --------- | ------- | ------- || npm        | stylelint | 16.16.0 | 16.17.0 |## [v16.17.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16170---2025-03-26)It adds 1 new rule, support for `languageOptions` to 2 rules, 1 option to a rule, the `--compute-edit-info` CLI flag (along with support for `EditInfo` in 3 rules), and fixes 1 bug. `EditInfo` is useful for automated fixing tools and editor integrations.-   Added: `layer-name-pattern` rule ([#8474](stylelint/stylelint#8474)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `--compute-edit-info` CLI flag ([#8473](stylelint/stylelint#8473)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `ignorePreludeOfAtRules: []` to `length-zero-no-unit` ([#8472](stylelint/stylelint#8472)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `at-rule-no-unknown` support for `languageOptions` ([#8475](stylelint/stylelint#8475)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `property-no-unknown` support for `languageOptions` ([#8476](stylelint/stylelint#8476)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `declaration-block-no-redundant-longhand-properties` support for computing `EditInfo` ([#8482](stylelint/stylelint#8482)) ([@pamelalozano16](https://github.com/pamelalozano16)).-   Added: `function-url-quotes` support for computing `EditInfo` ([#8483](stylelint/stylelint#8483)) ([@pamelalozano16](https://github.com/pamelalozano16)).-   Added: `selector-attribute-quotes` support for computing `EditInfo` ([#8484](stylelint/stylelint#8484)) ([@pamelalozano16](https://github.com/pamelalozano16)).-   Fixed: `custom-property-pattern` false negatives for `@property` preludes ([#8468](stylelint/stylelint#8468)) ([@rohitgs28](https://github.com/rohitgs28)).
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestMar 28, 2025
| datasource | package   | from    | to      || ---------- | --------- | ------- | ------- || npm        | stylelint | 16.16.0 | 16.17.0 |## [v16.17.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16170---2025-03-26)It adds 1 new rule, support for `languageOptions` to 2 rules, 1 option to a rule, the `--compute-edit-info` CLI flag (along with support for `EditInfo` in 3 rules), and fixes 1 bug. `EditInfo` is useful for automated fixing tools and editor integrations.-   Added: `layer-name-pattern` rule ([#8474](stylelint/stylelint#8474)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `--compute-edit-info` CLI flag ([#8473](stylelint/stylelint#8473)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `ignorePreludeOfAtRules: []` to `length-zero-no-unit` ([#8472](stylelint/stylelint#8472)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `at-rule-no-unknown` support for `languageOptions` ([#8475](stylelint/stylelint#8475)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `property-no-unknown` support for `languageOptions` ([#8476](stylelint/stylelint#8476)) ([@ryo-manba](https://github.com/ryo-manba)).-   Added: `declaration-block-no-redundant-longhand-properties` support for computing `EditInfo` ([#8482](stylelint/stylelint#8482)) ([@pamelalozano16](https://github.com/pamelalozano16)).-   Added: `function-url-quotes` support for computing `EditInfo` ([#8483](stylelint/stylelint#8483)) ([@pamelalozano16](https://github.com/pamelalozano16)).-   Added: `selector-attribute-quotes` support for computing `EditInfo` ([#8484](stylelint/stylelint#8484)) ([@pamelalozano16](https://github.com/pamelalozano16)).-   Fixed: `custom-property-pattern` false negatives for `@property` preludes ([#8468](stylelint/stylelint#8468)) ([@rohitgs28](https://github.com/rohitgs28)).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@MouvediaMouvediaMouvedia left review comments

@ybiquitousybiquitousybiquitous approved these changes

@jeddy3jeddy3jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addat-rule-no-unknown support forlanguageOptions
4 participants
@ryo-manba@Mouvedia@ybiquitous@jeddy3
[8]ページ先頭
©2009-2025 Movatter.jp