Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CLI: Corrected Next.js createScript for pnpm.#30304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

zhyd1997
Copy link
Contributor

@zhyd1997zhyd1997 commentedJan 18, 2025
edited by storybook-pr-benchmarkingbot
Loading

Closes#30291

What I did

pnpm create next-app@^14. --typescript --use-pnpm --eslint --tailwind --no-app --import-alias="@/*" --src-dir
Screenshot 2025-01-18 at 21 40 29

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to addci:normal,ci:merged orci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR containsone of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentationonly changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the@storybookjs/core team here.

core team members can create a canary releasehere or locally withgh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

namebeforeafterdiffz%
createSize0 B0 B0 B--
generateSize77.9 MB77.9 MB298 B1.110%
initSize131 MB131 MB412 B1.20%
diffSize53 MB53 MB114 B1.250%
buildSize7.19 MB7.19 MB0 B0.820%
buildSbAddonsSize1.85 MB1.85 MB0 B-0.820%
buildSbCommonSize195 kB195 kB0 B-0%
buildSbManagerSize1.87 MB1.87 MB0 B0.820%
buildSbPreviewSize0 B0 B0 B--
buildStaticSize0 B0 B0 B--
buildPrebuildSize3.91 MB3.91 MB0 B0.820%
buildPreviewSize3.28 MB3.28 MB0 B0.820%
testBuildSize0 B0 B0 B--
testBuildSbAddonsSize0 B0 B0 B--
testBuildSbCommonSize0 B0 B0 B--
testBuildSbManagerSize0 B0 B0 B--
testBuildSbPreviewSize0 B0 B0 B--
testBuildStaticSize0 B0 B0 B--
testBuildPrebuildSize0 B0 B0 B--
testBuildPreviewSize0 B0 B0 B--
namebeforeafterdiffz%
createTime26.1s24s-2s -176ms1.44🔰-9.1%
generateTime18.6s19.8s1.1s-0.645.9%
initTime12.5s14.4s1.8s-0.1213.2%
buildTime10.2s8.7s-1s -469ms-0.68-16.8%
testBuildTime0ms0ms0ms--
devPreviewResponsive4.6s5.3s657ms0.9412.3%
devManagerResponsive3.3s3.8s430ms1.2211.3%
devManagerHeaderVisible519ms641ms122ms1.1619%
devManagerIndexVisible527ms672ms145ms0.7821.6%
devStoryVisibleUncached1.8s1s-785ms-3.25🔰-72%
devStoryVisible590ms673ms83ms1.1412.3%
devAutodocsVisible508ms624ms116ms1.93🔺18.6%
devMDXVisible494ms569ms75ms0.6513.2%
buildManagerHeaderVisible552ms720ms168ms3.36🔺23.3%
buildManagerIndexVisible654ms737ms83ms1.78🔺11.3%
buildStoryVisible538ms697ms159ms3.53🔺22.8%
buildAutodocsVisible439ms517ms78ms0.8715.1%
buildMDXVisible420ms533ms113ms2.15🔺21.2%

Greptile Summary

Fixed incorrect version specifier format in Next.js project creation command for pnpm, resolving a 404 error during project initialization.

  • Changed version specifier fromnext-app^14 tonext-app@^14 incode/lib/create-storybook/src/scaffold-new-project.ts
  • Fixed pnpm trying to fetch non-existent package 'create-next-app14'
  • Aligned pnpm command syntax with npm/yarn version specifier format

💡 (1/5) You can manually trigger the bot by mentioning@greptileai in a comment!

greptile-apps[bot] reacted with thumbs up emoji
Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings |Greptile

Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings |Greptile

@nx-cloudNx Cloud
Copy link

View yourCI Pipeline Execution ↗ for commit6c6203b.

CommandStatusDurationResult
nx run-many -t build --parallel=3✅ Succeeded1m 43sView ↗

☁️Nx Cloud last updated this comment at2025-01-18 13:51:53 UTC

@zhyd1997zhyd1997 changed the titlefix: corrected nextjscreateScript forpnpm.create-storybook: corrected nextjscreateScript forpnpm.Jan 21, 2025
Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings |Greptile

@valentinpalkovicvalentinpalkovic added the patch:yesBugfix & documentation PR that need to be picked to main branch labelJan 23, 2025
@storybook-pr-benchmarking

Package Benchmarks

Commit:6c6203b, ran on 23 January 2025 at 11:22:32 UTC

The following packages have significant changes to their size or dependencies:

@storybook/react-native-web-vite

BeforeAfterDifference
Dependency count137114🎉 -23 🎉
Self size43 KB43 KB🎉 -250 B 🎉
Dependency size19.89 MB18.25 MB🎉 -1.64 MB 🎉
Bundle Size AnalyzerLinkLink

@valentinpalkovicvalentinpalkovic changed the titlecreate-storybook: corrected nextjscreateScript forpnpm.CLI: Corrected Next.jscreateScript forpnpm.Jan 23, 2025
@valentinpalkovicvalentinpalkovic changed the titleCLI: Corrected Next.jscreateScript forpnpm.CLI: Corrected Next.js createScript for pnpm.Jan 23, 2025
@valentinpalkovicvalentinpalkovic merged commit3d390e2 intostorybookjs:nextJan 23, 2025
67 of 78 checks passed
Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings |Greptile

@github-actionsgithub-actionsbot mentioned this pull requestJan 23, 2025
7 tasks
@zhyd1997zhyd1997 deleted the fix/issue-30291-zhyd1997-1737207908875 branchJanuary 23, 2025 11:46
@github-actionsgithub-actionsbot mentioned this pull requestJan 24, 2025
5 tasks
valentinpalkovic added a commit that referenced this pull requestJan 27, 2025
…207908875CLI: Corrected Next.js createScript for pnpm.(cherry picked from commit3d390e2)
@github-actionsgithub-actionsbot added the patch:donePatch/release PRs already cherry-picked to main/release branch labelJan 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments

@valentinpalkovicvalentinpalkovicvalentinpalkovic approved these changes

Labels
bugci:normalclinextjspatch:donePatch/release PRs already cherry-picked to main/release branchpatch:yesBugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Initial Next.JS template failed
2 participants
@zhyd1997@valentinpalkovic

[8]ページ先頭

©2009-2025 Movatter.jp