Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(rolldown)!: update tooxc@0.70.0 to refine printing comments#4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hyf0 merged 6 commits intomainfromnext-oxc
May 16, 2025

Conversation

Boshen
Copy link
Member

@BoshenBoshen commentedMay 15, 2025•
edited by hyf0
Loading

Description

This PR align rolldown's printing commens with esbuild:

  • Normal comments would be removed
  • Annotation comments will be printed always
  • legalComments is controlled byOutputOptions#legalComments

zsilbi reacted with rocket emoji
@netlifyNetlify
Copy link

netlifybot commentedMay 15, 2025•
edited
Loading

✅ Deploy Preview forrolldown-rs canceled.

NameLink
🔨 Latest commitfc1467d
🔍 Latest deploy loghttps://app.netlify.com/projects/rolldown-rs/deploys/6826f1dec1170f0008207e5f

@socket-securitySocket Security
Copy link

socket-securitybot commentedMay 15, 2025•
edited
Loading

Review the following changes in direct dependencies. Learn more aboutSocket for GitHub.

DiffPackageSupply Chain
Security		VulnerabilityQualityMaintenanceLicense
Added@​types/​strip-comments@​2.0.4991006976100
Added@​oxc-project/​types@​0.70.01001007096100
Added@​oxc-project/​runtime@​0.70.0921007395100

View full report

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedMay 15, 2025•
edited
Loading

Benchmarks Rust

group                                                               pr                                     target-----                                                               --                                     ------bundle/bundle@multi-duplicated-top-level-symbol                     1.01     74.7±0.96ms        ? ?/sec    1.00     73.7±0.77ms        ? ?/secbundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     93.7±0.64ms        ? ?/sec    1.01     94.4±0.58ms        ? ?/secbundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    106.9±0.91ms        ? ?/sec    1.01    107.7±0.72ms        ? ?/secbundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     84.5±0.88ms        ? ?/sec    1.00     83.9±0.61ms        ? ?/secbundle/bundle@rome-ts                                               1.00    115.8±0.68ms        ? ?/sec    1.01    116.9±0.99ms        ? ?/secbundle/bundle@rome-ts-minify                                        1.00    188.9±3.82ms        ? ?/sec    1.01    190.6±1.86ms        ? ?/secbundle/bundle@rome-ts-minify-sourcemap                              1.00    221.7±2.41ms        ? ?/sec    1.02    225.9±1.88ms        ? ?/secbundle/bundle@rome-ts-sourcemap                                     1.00    128.4±0.89ms        ? ?/sec    1.01    129.7±1.51ms        ? ?/secbundle/bundle@threejs                                               1.00     39.0±0.56ms        ? ?/sec    1.04     40.6±1.59ms        ? ?/secbundle/bundle@threejs-minify                                        1.00     81.2±0.69ms        ? ?/sec    1.02     82.9±0.39ms        ? ?/secbundle/bundle@threejs-minify-sourcemap                              1.00     96.6±1.93ms        ? ?/sec    1.02     98.4±0.41ms        ? ?/secbundle/bundle@threejs-sourcemap                                     1.00     45.7±0.35ms        ? ?/sec    1.02     46.6±0.28ms        ? ?/secbundle/bundle@threejs10x                                            1.00    411.6±6.56ms        ? ?/sec    1.02    419.1±2.88ms        ? ?/secbundle/bundle@threejs10x-minify                                     1.00   1007.9±5.09ms        ? ?/sec    1.02   1026.8±3.90ms        ? ?/secbundle/bundle@threejs10x-minify-sourcemap                           1.00   1179.0±6.71ms        ? ?/sec    1.02   1207.5±5.80ms        ? ?/secbundle/bundle@threejs10x-sourcemap                                  1.00    481.2±2.89ms        ? ?/sec    1.01    487.4±5.30ms        ? ?/secremapping/remapping                                                 1.00     24.9±0.37ms        ? ?/sec    1.08     26.9±1.27ms        ? ?/secremapping/render-chunk-remapping                                    1.00     70.7±5.35ms        ? ?/sec    1.01     71.6±4.85ms        ? ?/secscan/scan@rome-ts                                                   1.01     90.4±1.32ms        ? ?/sec    1.00     89.5±1.15ms        ? ?/secscan/scan@threejs                                                   1.00     30.5±0.37ms        ? ?/sec    1.00     30.4±1.24ms        ? ?/secscan/scan@threejs10x                                                1.00    306.8±3.05ms        ? ?/sec    1.00    306.2±2.74ms        ? ?/sec

@hyf0hyf0 changed the titlefeat(rolldown): oxc v0.70.0feat(rolldown)!: update tooxc@0.70.0 to rework of printing commentsMay 16, 2025
@hyf0hyf0 changed the titlefeat(rolldown)!: update tooxc@0.70.0 to rework of printing commentsfeat(rolldown)!: update tooxc@0.70.0 to refine printing commentsMay 16, 2025
@hyf0hyf0 marked this pull request as ready for reviewMay 16, 2025 08:21
@CopilotCopilotAI review requested due to automatic review settingsMay 16, 2025 08:21
@hyf0hyf0 added this pull request to themerge queueMay 16, 2025
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR upgrades the bundled Oxc version to 0.70.0 and adjusts how comments are emitted—normal comments are stripped, annotation comments are kept, and thelegalComments option now drives legal comment emission. Snapshots and inline test diffs are updated to reflect the new single-line, comment-stripped output.

  • Bumpoxc,oxc_parser_napi, andoxc_transform_napi to 0.70.0
  • Change defaultlegal_comments fromPreserve toInline
  • SwitchCodegenOptions logic to use the new minifier API
  • Regenerate and collapse test snapshots to match ESBuild-style printing

Reviewed Changes

Copilot reviewed 65 out of 65 changed files in this pull request and generated 2 comments.

FileDescription
Cargo.tomlBumped oxc crates to 0.70.0 and updated resolver note
crates/rolldown/src/utils/normalize_options.rsChanged defaultlegal_comments toInline
crates/rolldown/src/stages/generate_stage/minify_assets.rsUpdatedCodegenOptions branches for whitespace removal
crates/rolldown/tests///.md & **/.snapRegenerated diffs and snapshots to collapse comments
Comments suppressed due to low confidence (2)

Cargo.toml:198

  • After bumping these dependencies, please verify that the README or migration guide is updated to reference any new or updated API surface in Oxc 0.70.0.
oxc = { version = "0.70.0", features = [... ] }

crates/rolldown/tests/esbuild/default/define_this/diff.md:38

  • [nitpick] These collapsed one-line snapshots are harder to diff by eye; consider structuring the snapshots to preserve minimal line breaks or comments for readability.
ok(1, 2, 3, 2 .baz, 1 .bar);

Merged via the queue intomain with commit1c583feMay 16, 2025
31 checks passed
@hyf0hyf0 deleted the next-oxc branchMay 16, 2025 08:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hyf0hyf0hyf0 approved these changes

Copilot code reviewCopilotCopilot left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Boshen@hyf0
[8]ページ先頭
©2009-2025 Movatter.jp