Commita40ae2e

authored

Fix race condition inMarkdownHooks

Running asynchronous code inside a `useEffect` causes race conditions.This is now handled correctly.ClosesGH-896.Reviewed-by: Titus Wormer <tituswormer@gmail.com>

1 parentad7f37f commita40ae2eCopy full SHA for a40ae2e

File tree

2 files changed

+30

-2

lines changed

lib
- index.js
test.jsx

2 files changed

+30

-2

lines changed

`‎lib/index.js`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -207,11 +207,18 @@ export function MarkdownHooks(options) {`
`207`	`207`
`208`	`208`	`useEffect(`
`209`	`209`	`function(){`
	`210`	`+letcancelled=false`
`210`	`211`	`constfile=createFile(options)`
`211`	`212`	`processor.run(processor.parse(file),file,function(error,tree){`
`212`		`-setError(error)`
`213`		`-setTree(tree)`
	`213`	`+if(!cancelled){`
	`214`	`+setError(error)`
	`215`	`+setTree(tree)`
	`216`	`+}`
`214`	`217`	`})`
	`218`	`+`
	`219`	`+return()=>{`
	`220`	`+cancelled=true`
	`221`	`+}`
`215`	`222`	`},`
`216`	`223`	`[`
`217`	`224`	`options.children,`

`‎test.jsx`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1165,6 +1165,27 @@ test('MarkdownHooks', async function (t) {`
`1165`	`1165`	`})`
`1166`	`1166`	`assert.equal(container.innerHTML,'Error: rejected')`
`1167`	`1167`	`})`
	`1168`	`+`
	`1169`	+awaitt.test('should support `MarkdownHooks` rerenders',asyncfunction(){
	`1170`	`+constpluginA=deferPlugin()`
	`1171`	`+constpluginB=deferPlugin()`
	`1172`	`+`
	`1173`	`+constresult=render(`
	`1174`	`+<MarkdownHookschildren={'a'}rehypePlugins={[pluginA.plugin]}/>`
	`1175`	`+)`
	`1176`	`+`
	`1177`	`+result.rerender(`
	`1178`	`+<MarkdownHookschildren={'b'}rehypePlugins={[pluginB.plugin]}/>`
	`1179`	`+)`
	`1180`	`+`
	`1181`	`+assert.equal(result.container.innerHTML,'')`
	`1182`	`+pluginB.resolve()`
	`1183`	`+pluginA.resolve()`
	`1184`	`+awaitwaitFor(()=>{`
	`1185`	`+assert.notEqual(result.container.innerHTML,'')`
	`1186`	`+})`
	`1187`	`+assert.equal(result.container.innerHTML,'<p>b</p>')`
	`1188`	`+})`
`1168`	`1189`	`})`
`1169`	`1190`
`1170`	`1191`	`/**`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commita40ae2e

File tree

2 files changed

2 files changed

`‎lib/index.js`

`‎test.jsx`

0 commit comments