Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ReplaceDisabledByDefault with disabling each cop#26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

shima-zu
Copy link
Contributor

@shima-zushima-zu commentedNov 20, 2024•
edited
Loading

Summary

WhenDisabledByDefault istrue, all cops are disabled in the default configuration. This means that all extension cops are disabled by default as well.

The extensions are outside the scope of omakase, anduser may not realize that it has been disabled.

Workaround

The following is workaround, but I don't want to write them in my configuration.

inherit_gem:rubocop-rails-omakase:rubocop.ymlinherit_from:  -.rubocop_todo.ymlrequire:  -rubocop-rspec  -rubocop-rspec_railsRSpec:Enabled:true...RSpecRails:Enabled:true...

@koic
Copy link
Contributor

IMHO, this seems like a reasonable change in the sense that it only affects the minimal set of cops targeted byrubocop-rails-omakase. From the perspective of dependencies, how 3rd-party cops that are not detected byrubocop-rails-omakase behave can reasonably be considered outside the scope of its influence.

It also appears to provide a solution to the issue raised in#14. While listing departments may introduce some redundancy, to my knowledge, there is currently no better method for specifying them.

shima-zu reacted with thumbs up emoji

@shima-zushima-zu requested a review fromkoicNovember 25, 2024 02:43
@shima-zushima-zuforce-pushed thereplace-DisabledByDefault-true branch fromb8fb7b1 to5a5b628CompareNovember 25, 2024 02:50
@koic
Copy link
Contributor

I'm not sure if this proposal will be accepted, but for now, squashing the commits into one would be appropriate.

When `DisabledByDefault` is `true`, all cops in the default configuration.This means that all extension cops are disabled by default.The extensions are outside the scope of omakase, and you may not realize that it has been disabled.
@shima-zushima-zuforce-pushed thereplace-DisabledByDefault-true branch from5a5b628 to1210690CompareNovember 25, 2024 11:09
Copy link
Member

@jeremyjeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Agreed. Let's try it.

shima-zu reacted with heart emoji
@jeremyjeremy merged commit9839dcd intorails:mainDec 3, 2024
@shima-zushima-zu deleted the replace-DisabledByDefault-true branchDecember 4, 2024 00:50
@koic
Copy link
Contributor

@jeremy As mentioned inrubocop/rubocop#13727, this configuration seems to improve usability in certain cases. Since several changes have been included after rubocop-rails-omakase 1.0.0, would it be possible to release a new version if it’s convenient?

jeremy reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jeremyjeremyjeremy approved these changes

@koickoicAwaiting requested review from koic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@shima-zu@koic@jeremy
[8]ページ先頭
©2009-2025 Movatter.jp