Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added option to specify ClientCertificateContext in .NET 8+#1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tyb-dev
Copy link
Contributor

Proposed Changes

This allows clients to send the full intermediate chain during the TLS handshake instead of relying on OS stores or AIA fetches, addressing issue#1864. It improves interoperability when servers don’t have intermediates installed or when environments lack internet access.
Keep behavior unchanged for netstandard2.0; the new API is only compiled for net8.0.
Split Public API “Unshipped” files per TFM and wire them via AdditionalFiles to satisfy the PublicApiAnalyzer for both net8.0 and netstandard2.0.

Types of Changes

What types of changes does your code introduce to this project?
Put anx in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put anx in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read theCONTRIBUTING.md document
  • I have signed the CA (seehttps://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

N/A

lukebakken and 0xfeeddeadbeef reacted with thumbs up emoji
@tyb-dev
Copy link
ContributorAuthor

I haven't signed the CA yet. If there's interest in this change, I'm happy to sign it so this PR can proceed.

@michaelklishin
Copy link
Contributor

@tyb-dev I definitely think there is interest in supporting this option (conditionally, on .NET 8+). Thank you!

Please email us asdescribed in the contributor CLA repo and we will send you a Box Sign signature request.

@lukebakkenlukebakken self-requested a reviewSeptember 5, 2025 16:43
@lukebakkenlukebakken self-assigned thisSep 5, 2025
@lukebakkenlukebakken added this to the7.2.0 milestoneSep 5, 2025
@lukebakkenlukebakken removed this from the7.2.0 milestoneNov 3, 2025
@lukebakkenlukebakken reopened thisNov 4, 2025
Copy link
Collaborator

@lukebakkenlukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A test is required. If you'd like to get the skeleton of a test in place in theprojects\Test\Integration\TestSsl.cs file I can ensure the correct certs are in place for CI runs.

@lukebakkenlukebakken added this to the7.2.0 milestoneNov 4, 2025
@lukebakkenlukebakkenforce-pushed thefeat/ssl-clientcert-chain branch 3 times, most recently fromc3995bd to9849f55CompareNovember 5, 2025 20:28
Fixesrabbitmq#1864.NET supports the ability to supply intermediate certificates as well asthe client certificate during mTLS setup. Without support for`ClientCertificateContext`, users must ensure that intermediate certsare available in the system cert store for the .NET runtime to find.These changes use certificates generated via `rabbitmq/tls-gen` usingthis command:```make CN=localhost -C one_intermediate```All SSL tests now provide a client certificate, because the RabbitMQconfiguration has changed to require them via via...```ssl_options.fail_if_no_peer_cert = true```
@lukebakkenlukebakkenforce-pushed thefeat/ssl-clientcert-chain branch from9849f55 toc91c7f5CompareNovember 5, 2025 21:10
@lukebakkenlukebakken merged commitafae979 intorabbitmq:mainNov 5, 2025
5 checks passed
This was referencedNov 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lukebakkenlukebakkenlukebakken approved these changes

Assignees

@lukebakkenlukebakken

Labels

None yet

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tyb-dev@michaelklishin@lukebakken

[8]ページ先頭

©2009-2025 Movatter.jp