Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Closes#1849: include a message id tag in rabbitmqactivitysource for published messages#1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@YayBurritos
Copy link
Contributor

@YayBurritosYayBurritos commentedJun 30, 2025•
edited
Loading

Proposed Changes

Addresses#1849.

Updated theRabbitMQActivitySource.BasicPublish method to allow forIReadOnlyBasicProperties to be passed in as an additional parameter. This allows theIReadOnlyBasicProperties to then be passed along to thePopulateMessagingTags method, which adds theMessageId as a tag.

Types of Changes

What types of changes does your code introduce to this project?
Put anx in the boxes that apply

Checklist

  • I have read theCONTRIBUTING.md document
  • I have signed the CA (seehttps://cla.pivotal.io/sign/rabbitmq) - I can't get to this link. Is it valid?
  • I have added tests that prove my fix is effective or that my feature works

@michaelklishinmichaelklishin changed the title1849 include messageid tag in rabbitmqactivitysource during basicpublishCloses#1849: include a message id tag in rabbitmqactivitysource for published messagesJul 1, 2025
@YayBurritos
Copy link
ContributorAuthor

YayBurritos commentedJul 14, 2025•
edited
Loading

@lukebakken : Here's the PR. I'm not sure how to assign Reviewers. I don't seem to have permission to do so, nor would I know who best to conduct the review and merge. Can you assist? Thanks!

@lukebakkenlukebakken self-assigned thisJul 14, 2025
@lukebakkenlukebakken added this to the7.2.0 milestoneJul 14, 2025
@lukebakken
Copy link
Collaborator

I'm hoping@stebet,@lmolkova and others more familiar with OTel can review this.

YayBurritos reacted with thumbs up emoji

@danielmarbach
Copy link
Collaborator

danielmarbach commentedJul 16, 2025 via email

Currently on longer vacation. Happy to review when back but it will take a whileAm 14.07.2025 18:50 schrieb Luke Bakken ***@***.***>:lukebakken left a comment (rabbitmq/rabbitmq-dotnet-client#1852)I'm hoping@stebet,@lmolkova and others more familiar with OTel can review this.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>

@YayBurritos
Copy link
ContributorAuthor

I'm hoping@stebet,@lmolkova and others more familiar with OTel can review this.

Can they be added as reviewers?

@lukebakkenlukebakkenforce-pushed the1849-include-messageid-tag-in-rabbitmqactivitysource-during-basicpublish branch fromc2d7511 to96b07b8CompareAugust 19, 2025 15:07
lukebakken
lukebakken previously approved these changesAug 19, 2025
…ageid tag to be included in trace spanupdated tests for messageid tagcorrected broken tests after bad conflict resolution from merging main into feature branch
@lukebakkenlukebakkenforce-pushed the1849-include-messageid-tag-in-rabbitmqactivitysource-during-basicpublish branch from96b07b8 toc1c54f1CompareAugust 19, 2025 15:17
@lukebakkenlukebakken merged commit8698fd6 intorabbitmq:mainAug 19, 2025
10 checks passed
This was referencedNov 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@danielmarbachdanielmarbachdanielmarbach left review comments

@lukebakkenlukebakkenlukebakken approved these changes

Assignees

@lukebakkenlukebakken

Labels

None yet

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@YayBurritos@lukebakken@danielmarbach
[8]ページ先頭
©2009-2025 Movatter.jp