- Notifications
You must be signed in to change notification settings - Fork615
Description
Is your feature request related to a problem? Please describe.
TheDeliver method ofRabbitMQActivitySource acceptsIReadOnlyBasicProperties as input. This allows theMessageId, if provided, to be added as a tag (span attribute) in thePopulateMessagingTags method:
if (!string.IsNullOrEmpty(readOnlyBasicProperties.MessageId)) { activity.SetTag(MessageId, readOnlyBasicProperties.MessageId); }However, theBasicPublish method currently doesn't acceptIReadOnlyBasicProperties as input, soMessageId can't be included.
HavingMessageId as a tag in both the "publish" and "deliver" trace spans will allow users to be able to find traces - both from the publisher and consumer perspective - if they know theMessageId, which could theoretically be obtained from application logs, an audit table, etc.
Describe the solution you'd like
I'd like to update theRabbitMQActivitySource.BasicPublish method to allow forIReadOnlyBasicProperties to be passed in as an additional parameter. That would allow theIReadOnlyBasicProperties to then be passed along to thePopulateMessagingTags method, which would add theMessageId as a tag.
Describe alternatives you've considered
No response
Additional context
No response