- Notifications
You must be signed in to change notification settings - Fork5.7k
Implement PEP 735 Dependency Groups#4800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
harshil21 wants to merge7 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR implements PEP 735 dependency groups, removes legacy requirement files, and updates CI/docs workflows to use pip’s--group installs.
- Define
tests,docs, andalldependency groups inpyproject.toml - Remove
requirements-*.txtfiles and switch workflows from-rinstalls to--groupflags - Reformat array syntax and lint settings in
pyproject.tomlfor consistency
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| requirements-unit-tests.txt | Removed legacy test requirements file |
| requirements-dev-all.txt | Removed legacy dev-all requirements file |
| pyproject.toml | Added[dependency-groups], collapsed arrays, updated optional-dependencies |
| docs/requirements-docs.txt | Removed legacy docs requirements file |
| .readthedocs.yml | Updated RTD install step—now onlypip install . |
| .github/workflows/unit_tests.yml | Switched topip install . --group tests, removed old installs |
| .github/workflows/test_official.yml | Switched topip install .[all] --group tests |
| .github/workflows/docs-linkcheck.yml | Switched topip install .[all] --group all |
| .github/workflows/docs-admonitions.yml | Switched topip install . --group all |
| .github/workflows/chango.yml | Switched topip install . --group docs |
| .github/CONTRIBUTING.rst | Updated contributor setup to use--group all |
Comments suppressed due to low confidence (3)
.readthedocs.yml:20
- The ReadTheDocs config no longer installs documentation dependencies. You should add an install argument to include the
docsgroup (e.g.,args: ["--group", "docs"]) so Sphinx requirements are pulled in.
- method: pip path: ..github/workflows/unit_tests.yml:41
- [nitpick] The
testsdependency group already includespytest-xdist, so this extra installation is redundant and can be removed.
python -W ignore -m pip install pytest-xdist.github/workflows/docs-admonitions.yml:34
- With the old requirements files removed, the cache no longer tracks dependency changes. Consider adding
cache-dependency-path: 'pyproject.toml'(or similar) to ensure the cache is invalidated when dependencies are updated.
- cache-dependency-path: '**/requirements*.txt'Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#4795.
Also ran the standard vscode file formatter on pyproject.toml, so if you're wondering about that change, it's that.
Also works with
uv:uv sync --all-extras --all-groups