- Notifications
You must be signed in to change notification settings - Fork5.7k
Start using MessageLimit.DEEP_LINK_LENGTH constant#4597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Bibo-Joshi merged 1 commit intopython-telegram-bot:masterfromnemacysts:use-deep-link-length-constantDec 7, 2024
Merged
Start using MessageLimit.DEEP_LINK_LENGTH constant#4597
Bibo-Joshi merged 1 commit intopython-telegram-bot:masterfromnemacysts:use-deep-link-length-constantDec 7, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This constant was added back inpython-telegram-bot#3315 - but it was never referenced inthe ptb codebase.However, as mentioned in a comment added inpython-telegram-bot#3351 - there was at leastone place that was hardcoding this value rather than referencing thenamed constantAs far as I can tell (with the help of `git grep`), this is likely theonly 64->MessageLimit.DEEP_LINK_LENGTH swap that can be made :)NOTE: I've verified that the formatting of the documentation looks thesame in terms of line breaks after breaking the ValueError exceptiontext into two lines (i.e., there's no extraneous newlines)
hmm, the failing |
Bibo-Joshi approved these changesDec 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice catch, thank you very much!
The failing test is just due to#4594 not being part of your branch, but that's indeed not your fault :)
cuevasrja pushed a commit to USB-CI3715/python-telegram-bot that referenced this pull requestDec 9, 2024
cuevasrja added a commit to USB-CI3715/python-telegram-bot that referenced this pull requestDec 13, 2024
…cia entre módulos (#1)* Refactor datetime imports to use alias for consistency* Refactor datetime imports to use alias for consistency across modules* Refactor datetime imports to use alias for consistency in ChatMemberUpdated, Giveaway, Message, MessageOrigin modules* Refactor datetime imports to use alias for consistency in ChatJoinRequest and ChatMember modules* Full Support for Bot API 8.0 (python-telegram-bot#4566,python-telegram-bot#4568,python-telegram-bot#4570,python-telegram-bot#4571,python-telegram-bot#4574,python-telegram-bot#4576,python-telegram-bot#4572)* Documentation Improvements (python-telegram-bot#4573,python-telegram-bot#4565)Co-authored-by: Snehashish Biswas <coderrx06@gmail.com>Co-authored-by: poolitzer <github@poolitzer.eu>* Bump Version to v21.8 (python-telegram-bot#4583)* Bump `srvaroa/labeler` from 1.11.1 to 1.12.0 (python-telegram-bot#4586)Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>* Bump `pylint` to v3.3.2 to Improve Python 3.13 Support (python-telegram-bot#4590)* Bump `codecov/codecov-action` from 4 to 5 (python-telegram-bot#4585)Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>* Allow `Sequence` Input for `allowed_updates` in `Application` and `Updater` Methods (python-telegram-bot#4589)* Full Support for Bot API 8.1 (python-telegram-bot#4594)* Use `MessageLimit.DEEP_LINK_LENGTH` in `helpers.create_deep_linked_url` (python-telegram-bot#4597)* Bump `pytest` from 8.3.3 to 8.3.4 (python-telegram-bot#4596)Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>* Update `aiolimiter` requirement from ~=1.1.0 to >=1.1,<1.3 (python-telegram-bot#4595)Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>* Bump Version to v21.9 (python-telegram-bot#4601)* Reorder imports to unify `datetime` usage across modules---------Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>Co-authored-by: Snehashish Biswas <coderrx06@gmail.com>Co-authored-by: poolitzer <github@poolitzer.eu>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Luis Pérez <luis.i.perez.0@gmail.com>Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>Co-authored-by: Juan Andrés Cuevas <juanandrescuevas14@gmail.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This constant was added back in#3315 - but it was never referenced in the ptb codebase.
However, as mentioned in a comment added in#3351 - there was at least one place that was hardcoding this value rather than referencing the named constant
As far as I can tell (with the help of
git grep), this is likely the only 64->MessageLimit.DEEP_LINK_LENGTH swap that can be made :)NOTE: I've verified that the formatting of the documentation looks the same in terms of line breaks after breaking the ValueError exception text into two lines (i.e., there's no extraneous newlines)
Verification:
make -C docs/ singlehtmland inspected the generated docs