Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix path traversal detection for windows#1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@codejedi365
Copy link
Contributor

@codejedi365codejedi365 commentedAug 31, 2024•
edited
Loading

Purpose

Rationale

@codejedi365codejedi365force-pushed thefix/windows-path-traversal-prevention branch 7 times, most recently from89fdc55 to95df869CompareSeptember 1, 2024 02:50
@codejedi365codejedi365 changed the base branch frommaster totest/validate-windows-implementationsSeptember 1, 2024 08:27
The original implementation of the path traversal detection expected that `resolve()`works the same on windows as it does with Linux/Mac. Windows requires the folder pathsto exist to be resolved and that is not the case when the `template_dir` is not beingused.Resolves:python-semantic-release#994
@codejedi365codejedi365force-pushed thefix/windows-path-traversal-prevention branch from95df869 tof422ea1CompareSeptember 1, 2024 08:29
@codejedi365codejedi365 merged commit7e0b850 intopython-semantic-release:test/validate-windows-implementationsSep 1, 2024
@codejedi365codejedi365 deleted the fix/windows-path-traversal-prevention branchSeptember 1, 2024 08:50
codejedi365 added a commit that referenced this pull requestSep 1, 2024
…1014)  The original implementation of the path traversal detection expected that `resolve()`  works the same on windows as it does with Linux/Mac. Windows requires the folder paths  to exist to be resolved and that is not the case when the `template_dir` is not being  used.Resolves:#994
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Getting "Template directory must be inside of the repository directory." error when not specifying template_dir option.

1 participant

@codejedi365
[8]ページ先頭
©2009-2025 Movatter.jp