NotificationsYou must be signed in to change notification settings
Fork2.9k
Star13.3k

Report class cleanup exceptions#12250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicoddemus merged 4 commits intopytest-dev:mainfrommillerdev:report-class-cleanup-exceptions

Apr 27, 2024

Merged

Report class cleanup exceptions#12250

nicoddemus merged 4 commits intopytest-dev:mainfrommillerdev:report-class-cleanup-exceptions

Apr 27, 2024

Conversation

Copy link

Contributor

millerdev commentedApr 26, 2024

Fixes#11728

millerdevand others added2 commits

April 26, 2024 10:41

Report class cleanup exceptions

4e13a5f

[pre-commit.ci] auto fixes from pre-commit.com hooks

e209a3d

for more information, seehttps://pre-commit.ci

nicoddemus mentioned this pull request

Apr 26, 2024

Show nicer tracebacks for BaseExceptionGroup from fixture setup/teardown#12255

Open

Use ExceptionGroup instead of printing, improve changelog

122fd05

nicoddemus approved these changes

Apr 26, 2024

View reviewed changes

Copy link

Member

nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@millerdev!

I changed the implementation a bit to raiseExceptionGroup instead of printing the tracebacks directly: printing at first glance seems fine, but this will not produce the desired effects (such as withxdist) because it will not go through the reporting protocols expected by plugins.

This unfortunately makes for a longer traceback (which we should improve in#12255), however I think this is the right path for now.