Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: possible infinite loop when parsing option#1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alexander-fenster merged 1 commit intomasterfromoptions-parse
Aug 21, 2023

Conversation

alexander-fenster
Copy link
Contributor

@alexander-fensteralexander-fenster commentedAug 17, 2023
edited
Loading

Thewhile loop inparseOptionValue can be infinite if the closing brace} it expects never comes.

const protobuf = require('protobufjs');protobuf.parse("option (foo).whatever = {");

Reported by@oetr.

Minor unrelated changes also in this PR, because I'm too lazy to create a separate one:

  • changedeslint-disable-line to a propereslint-disable-next-line in a few places to fix linting errors;
  • removed extra logging in one of the tests.

@alexander-fensteralexander-fenster merged commitf2a8620 intomasterAug 21, 2023
@github-actionsgithub-actionsbot mentioned this pull requestAug 21, 2023
@dcodeIOdcodeIO deleted the options-parse branchMay 24, 2024 12:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bcoebcoebcoe approved these changes

Assignees

@bcoebcoe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-fenster@bcoe

[8]ページ先頭

©2009-2025 Movatter.jp