Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(linter): Implement no-useless-call rule#8789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Boshen merged 8 commits intooxc-project:mainfromkeita-hino:no-useless-call
Jan 31, 2025

Conversation

@graphite-appGraphite App
Copy link
Contributor

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up usingthis link.

An organization admin has enabled theGraphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actionsgithub-actionsbot added A-linterArea - Linter C-enhancementCategory - New feature or request labelsJan 30, 2025
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedJan 30, 2025
edited
Loading

CodSpeed Performance Report

Merging#8789 willnot alter performance

Comparingkeita-hino:no-useless-call (4cc62fb) withmain (8ce21d1)

Summary

✅ 33 untouched benchmarks

@github-actionsgithub-actionsbot added the A-cliArea - CLI labelJan 30, 2025
graphite-appbot pushed a commit that referenced this pull requestJan 30, 2025
it is only removing one test. This test is removed because of:#8789 (comment)Boshen thought too that this should be a problem in the future. I did not believe him :/Merging without review
Copy link
Member

@SysixSysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for your work. I have some small changes to request.
The implementation looks great 👍

keita-hino reacted with heart emoji
@keita-hino
Copy link
ContributorAuthor

@Sysix
Thank you for the review! I’ve made the changes, so please review it again 🙏

@BoshenBoshen merged commitadb8ebd intooxc-project:mainJan 31, 2025
26 checks passed
@oxc-botoxc-bot mentioned this pull requestFeb 1, 2025
Boshen added a commit that referenced this pull requestFeb 1, 2025
## [0.15.9] - 2025-02-01### Features-1a41181 linter: Implement `eslint/prefer-object-spread` (#8216)(tbashiyy)-adb8ebd linter: Implement no-useless-call rule (#8789) (keita hino)-3790933 linter: Add vitest/prefer-lowercase-title rule (#8152) (TylerEarls)-e8e6917 linter: Unicorn/switch-cases-braces support options (#8704)(1zumii)### Bug Fixes-8ce21d1 linter: Can't disable `no-nested-ternary` rule anymore (#8600)(dalaoshu)-e929f26 linter: Output `LintCommandInfo` for`CliRunResult::LintNoFilesFound` (#8714) (Sysix)-4f30a17 linter: Unicorn/switch-case-braces mangles code when applyingfix (#8758) (Tyler Earls)- 9cc9d5f linter: `ignorePatterns` does not work when files are providedas command arguments (#8590) (dalaoshu)-1de6f85 linter: No-lone-blocks erroring on block statements containingcomments (#8720) (Tyler Earls)-77ef61a linter: Fix diagnostic spans for `oxc/no-async-await` (#8721)(camchenry)-f15bdce linter: Catch `Promise` in `typescript/array-type` rule(#8702) (Rintaro Itokawa)- 5041cb3 vscode: Fix commands by reverting commit `259a47b` (#8819)(Alexander S.)### Performance-d318238 linter: Remove sorting of rules in cache (#8718) (camchenry)### Documentation-57b7ca8 ast: Add documentation for all remaining JS AST methods(#8820) (Cam McHenry)### Refactor-c2fdfc4 linter: Correctly handle loose options for `eslint/eqeqeq`(#8798) (dalaoshu)- 0aeaedd linter: Support loose options for `eslint/eqeqeq` (#8790)(dalaoshu)-194a5ff linter: Remove `LintResult` (#8712) (Sysix)-4a2f2a9 linter: Move default `all_rules` output to trait (#8710)(Sysix)-741fb40 linter: Move stdout outside LintRunner (#8694) (Sysix)-10e5920 linter: Move finishing default diagnostic message to`GraphicalReporter` (#8683) (Sysix)-9731c56 oxlint: Move output from `CliRunResult::InvalidOption` tooutside and use more Enums for different invalid options (#8778) (Sysix)-fe45bee oxlint: Create different `CliRunResult` instead of passing`ExitCode` to it (#8777) (Sysix)-2378fef oxlint: Move ConfigFileInit output outside CliRunResult, exitcode 1 when it fails (#8776) (Sysix)- f4cecb5 oxlint: Remove unused `CliRunResult::PathNotFound` (#8775)(Sysix)### Testing- ad35e82 linter: Use snapshot testing instead of LintResult (#8711)(Sysix)- bf895eb linter: Add diagnostic format test snapshots (#8696)(Alexander S.)-34d3d72 linter: Add snapshot tester for cli (#8695) (Sysix)-0bf2bcf oxlint: Test two real rules with same name but from differentplugins (#8821) (dalaoshu)-2b83b71 oxlint: Improve disabling "no-nested-ternary" tests (#8814)(Alexander S.)-45648e7 oxlint: Fix InvalidOptionTsConfig tests for windows (#8791)(Alexander S.)-48bfed9 oxlint: Ignore windows path mismatch (Boshen)-6f4a023 oxlint: Remove "--print-config" test (#8792) (Sysix)-55c2025 oxlint: Add `CliRunResult` to snapshot (#8780) (Sysix)Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SysixSysixSysix approved these changes

Assignees
No one assigned
Labels
A-cliArea - CLIA-linterArea - LinterC-enhancementCategory - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@keita-hino@Sysix@Boshen

[8]ページ先頭

©2009-2025 Movatter.jp