- Notifications
You must be signed in to change notification settings - Fork1.4k
debug: Fixing step-over behaviour when exiting partial rules#7096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
johanfylling merged 4 commits intoopen-policy-agent:mainfromjohanfylling:debug/fix_partial-rule_step-overOct 4, 2024
Merged
debug: Fixing step-over behaviour when exiting partial rules#7096
johanfylling merged 4 commits intoopen-policy-agent:mainfromjohanfylling:debug/fix_partial-rule_step-overOct 4, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The step-over action would previously skip over any associated partial "sibling" rules if performed on the last statement of a partial rule.Now, step-over will break on any `enter` operation immediately preceded by an `exit` or `fail` operation; effectively breaking on every visited partial rule sharing a node in the rule-tree.Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
ashutosh-narkar approved these changesOct 3, 2024
61c551c intoopen-policy-agent:main 28 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The step-over debug action would previously skip over any associated partial "sibling" rules if performed on the last statement of a partial rule. Now, step-over will break on any
enteroperation immediately preceded by anexitorfailoperation; effectively breaking on every visited partial rule sharing a node in the rule-tree.