- Notifications
You must be signed in to change notification settings - Fork1.5k
Preserve user provided http headers in aws.sign_req#6456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+15 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Currently while all the headers are signed the headers in thereturned object are missing all the original user provided headersThis means that if you pass the object directly to http.sendamazon will fail the request because the signed data doesn't matchthe canonical request. Users can work around it by using object.unionto restore the original headers, but would be nice to avoid that extrastepSigned-off-by: Peter <c2zwdjnlcg@users.noreply.github.com>
ashutosh-narkar approved these changesDec 12, 2023
Member
ashutosh-narkar left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks@c2zwdjnlcg!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently while all the headers are signed the headers in the returned object are missing all the original user provided headers This means that if you pass the object directly to http.send amazon will fail the request because the signed data doesn't match the canonical request. Users can work around it by using object.union to restore the original headers, but would be nice to avoid that extra step