Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow non-HTTPS issuer when OAUTHLIB_INSECURE_TRANSPORT.#803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
auvipy merged 2 commits intooauthlib:masterfromluhn:metadata-issuer-insecure
Mar 6, 2022

Conversation

luhn
Copy link
Contributor

@luhnluhn commentedFeb 4, 2022

Useutils.is_secure_transport to validate issuer, that wayOAUTHLIB_INSECURE_TRANSPORT is taken into account.

@luhn
Copy link
ContributorAuthor

luhn commentedFeb 4, 2022

I was going off of the existing unit tests for the metadata endpoint, which don't seem to test the validations? Likely because the validations don't result in a user-facing error but a hardValueError.

Happy to whip up a quick test if you'd still like me to.

@auvipy
Copy link
Contributor

yes please

Copy link
Member

@JonathanHuotJonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@JonathanHuotJonathanHuot added this to the3.2.1 milestoneFeb 18, 2022
@JonathanHuotJonathanHuot added the OAuth2-ProviderThis impact the provider part of OAuth2 labelFeb 18, 2022
@auvipyauvipy merged commitb123283 intooauthlib:masterMar 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JonathanHuotJonathanHuotJonathanHuot approved these changes

@auvipyauvipyauvipy approved these changes

Assignees
No one assigned
Labels
OAuth2-ProviderThis impact the provider part of OAuth2
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

3 participants
@luhn@auvipy@JonathanHuot
[8]ページ先頭
©2009-2025 Movatter.jp