Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BUG: Correct ambiguous logic for s390x CPU feature detection#29701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
charris merged 1 commit intonumpy:maintenance/2.3.xfromcharris:backport-29697
Sep 6, 2025

Conversation

@charris
Copy link
Member

Backport#29697.

This PR continues the work from#29678 to improve CPU feature detection in the Meson build system, specifically for thes390x architecture.

Problem:
The current detection forVXE andVXE2 is ambiguous:

  • VXE2: The regex 'VX.*' is overly greedy and could match any string containing “VX”.
  • VXE: The simple match for 'VX' could incorrectly enable VXE on systems that only support VX.

These ambiguities may cause NumPy to compile with unsupported CPU instructions, risking Illegal Instruction crashes or performance issues.

Solution:
This PR replaces the fragile patterns with precise regular expressions using word boundaries (\b):

  • VXE → '\\bvxe\\b'
  • VXE2 → '\\bvxe2\\b'

No changes are made to the feature hierarchy, compiler flags, or test code.

@charrischarris added this to the2.3.3 release milestoneSep 6, 2025
@charrischarris added 00 - Bug 08 - BackportUsed to tag backport PRs labelsSep 6, 2025
@charrischarris merged commitf024265 intonumpy:maintenance/2.3.xSep 6, 2025
75 checks passed
@charrischarris deleted the backport-29697 branchSeptember 6, 2025 20:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

00 - Bug08 - BackportUsed to tag backport PRs

Projects

None yet

Milestone

2.3.3 release

Development

Successfully merging this pull request may close these issues.

2 participants

@charris@Sanjaykumar030

[8]ページ先頭

©2009-2025 Movatter.jp