Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/nxPublic

fix(bundling): remove migration always adding sass-embedded#30276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FrozenPandaz merged 1 commit intomasterfromremove-sass-embedded-miog
Mar 5, 2025

Conversation

Coly010
Copy link
Contributor

Current Behavior

There is a migration that always addssass-embedded for Rspack and Webpack for 20.5

Expected Behavior

sass-embedded is already a dependency of Rspack and Webpack and therefore does not need to be added to users package.json - especially as they may not be using it.

@Coly010Coly010 requested review froma team ascode ownersMarch 5, 2025 16:20
@Coly010Coly010 requested a review frommandariniMarch 5, 2025 16:20
@Coly010Coly010 self-assigned thisMar 5, 2025
@vercelVercel
Copy link

vercelbot commentedMar 5, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nx-dev✅ Ready (Inspect)Visit PreviewMar 5, 2025 4:34pm

@nx-cloudNx Cloud
Copy link
Contributor

nx-cloudbot commentedMar 5, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit2db023a.

CommandStatusDurationResult
nx affected --targets=lint,test,build,e2e,e2e-c...✅ Succeeded32m 34sView ↗
nx run-many -t check-imports check-commit check...✅ Succeeded16sView ↗
nx-cloud record -- nx-cloud conformance:check✅ Succeeded2sView ↗
nx-cloud record -- nx format:check --base=00e97...✅ Succeeded1sView ↗
nx-cloud record -- nx sync:check✅ Succeeded1sView ↗
nx documentation✅ Succeeded1m 31sView ↗

☁️Nx Cloud last updated this comment at2025-03-05 16:59:22 UTC

@FrozenPandazFrozenPandaz merged commit648129f intomasterMar 5, 2025
12 checks passed
@FrozenPandazFrozenPandaz deleted the remove-sass-embedded-miog branchMarch 5, 2025 19:12
@github-actionsGitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ndcunninghamndcunninghamndcunningham approved these changes

@FrozenPandazFrozenPandazFrozenPandaz approved these changes

@mandarinimandariniAwaiting requested review from mandarinimandarini is a code owner automatically assigned from nrwl/nx-js-reviewers

@leosvelperezleosvelperezAwaiting requested review from leosvelperezleosvelperez is a code owner automatically assigned from nrwl/nx-docs-reviewers

Assignees

@Coly010Coly010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Coly010@ndcunningham@FrozenPandaz
[8]ページ先頭
©2009-2025 Movatter.jp